-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: go mod vendor removes files in 1.13 that were present on 1.12 #33353
Comments
You may want to look at #31088. |
Got it, so to my understanding, projects that will do CI with multiple Go versions including 1.13 and ship the |
/cc @bcmills @jayconrod |
You should not need to re-vendor: all That is: the removed files should be irrelevant to the build. If you find otherwise, please provide more detail. |
Currently I've seen this on Prometheus repo where I ran "go mod vendor" on Go 1.13 and pushed the changes. Their CI runs and returns error since they compare a "go mod vendor" ran on 1.11 or 1.12 with the PR that has less files. |
If that's the only symptom, probably they should update that CI script to not make assumptions about irrelevant files, or update their contributing instructions to be more explicit about the |
@bcmills I totally agree with you, I'll try to get in touch with them pointing this out. |
Thanks. It sounds like everything is working as designed for #31088, but please do let us know if you encounter other symptoms that were not intended (such as broken |
Thanks. We already document which Go version should be used but we'll probably issue an extra announcement to our -dev list to raise awareness. As for the CI, it runs against only one version of Go so we'll only have to update the |
What version of Go are you using (
go version
)?Comparing Go 1.13 beta1 with go 1.12.7:
Does this issue reproduce with the latest release?
The problem occurs on latest 1.13 tree.
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Testing in Docker containers for both versions (
docker run -it --rm golang:1.12 bash
anddocker run -it --rm golang:1.13beta1-alpine3.10 sh
), I checked-out Prometheus tree and rango mod vendor
. On 1.12 my module deps were kept intact but on 1.13 many files were removed. Below the walkthru:Go 1.12
Go 1.13
What did you expect to see?
The modules should be kept intact in
vendor
dir on version 1.13.What did you see instead?
Many files removed as seen above in
git status
command for 1.13.The text was updated successfully, but these errors were encountered: