Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for go mod vendor command #1322

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Fix for go mod vendor command #1322

merged 2 commits into from
Feb 5, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Feb 5, 2020

Some modules are not needed as well as some test files in a vendor directory.

See golang/go#33353 for the reference

@aLekSer
Fix for go mod vendor command
948c5c3 
`go mod verify` returns no error
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 22c0bed4-ec35-4741-bbe9-a5bfa5ddebf5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1322/head:pr_1322 && git checkout pr_1322
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-948c5c3

@aLekSer
Copy link
Collaborator Author

aLekSer commented Feb 5, 2020

This could be applied independently of PR #1321. Checked that result is the same.

@aLekSer aLekSer marked this pull request as ready for review February 5, 2020 13:23
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7ed16d04-8caf-45b1-a873-379a4c532a14

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1322/head:pr_1322 && git checkout pr_1322
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-89d917b

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 0a98633 into googleforgames:master Feb 5, 2020
@markmandel markmandel added this to the 1.4.0 milestone Feb 26, 2020
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/bug These are bugs. labels Feb 26, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @roberthbailey @ilkercelikyilmaz
Fix for go mod vendor command (googleforgames#1322)
93bb84e 
`go mod verify` returns no error

Co-authored-by: Robert Bailey <robertbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@markmandel markmandel

Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/bug These are bugs. lgtm size/XXL
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aLekSer @agones-bot @google-oss-robot @markmandel @roberthbailey