Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x509: marshalBasicConstraints should return error in case of marshalling error #50663

Closed
aberenguel opened this issue Jan 18, 2022 · 2 comments
Closed

x509: marshalBasicConstraints should return error in case of marshalling error #50663

aberenguel opened this issue Jan 18, 2022 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.19

Comments

@aberenguel
Copy link

go/src/crypto/x509/x509.go

Line 1311 in 897b3da

return ext, nil

cuiweixie added a commit to cuiweixie/go that referenced this issue Jan 18, 2022
@cuiweixie
crypto: return err instead of nil
2af70aa 
Fixed: golang#50663
@cuiweixie cuiweixie mentioned this issue Jan 18, 2022
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/379094 mentions this issue: crypto: return err instead of nil

@heschi
Copy link
Contributor

heschi commented Jan 20, 2022

cc @FiloSottile@agl @katiehockman @rolandshoemaker

@heschi heschi added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 20, 2022
@heschi heschi added this to the Go1.19 milestone Jan 20, 2022
cuiweixie added a commit to cuiweixie/go that referenced this issue Jan 20, 2022
@cuiweixie
crypto: return err ans1.Marshal gives an error
e499017 
Fixes golang#50663
cuiweixie added a commit to cuiweixie/go that referenced this issue Jan 21, 2022
@cuiweixie
crypto/x509: return err ans1.Marshal gives an error
fcb6a29 
Fixes golang#50663
@katiehockman katiehockman added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 21, 2022
cuiweixie added a commit to cuiweixie/go that referenced this issue Jan 22, 2022
@cuiweixie
crypto/x509: return err ans1.Marshal gives an error
9a86d5b 
Fixes golang#50663
cuiweixie added a commit to cuiweixie/go that referenced this issue Feb 1, 2022
@cuiweixie
crypto/x509: return err ans1.Marshal gives an error
57ff5dd 
Fixes golang#50663
@seankhliao seankhliao changed the title x509.marshalBasicConstraints should return error in case of marshalling error x509: marshalBasicConstraints should return error in case of marshalling error Feb 8, 2022
@golang golang locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.19
Development

Successfully merging a pull request may close this issue.

crypto/x509: return err ans1.Marshal gives an error cuiweixie/go
5 participants
@aberenguel @rolandshoemaker @gopherbot @heschi @katiehockman