Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: return err ans1.Marshal gives an error #50667

Closed
wants to merge 1 commit into from
Closed

crypto/x509: return err ans1.Marshal gives an error #50667

wants to merge 1 commit into from

Conversation

cuiweixie
Copy link
Contributor

@cuiweixie cuiweixie commented Jan 18, 2022 •
edited
Loading

Fixes #50663

@gopherbot
Copy link
Contributor

This PR (HEAD: 2af70aa) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/379094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Katie Hockman:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/379094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: e499017) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/379094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@cuiweixie cuiweixie changed the title crypto: return err instead of nil crypto: return err ans1.Marshal gives an error Jan 21, 2022
@cuiweixie cuiweixie changed the title crypto: return err ans1.Marshal gives an error crypto/x509: return err ans1.Marshal gives an error Jan 21, 2022
@gopherbot
Copy link
Contributor

This PR (HEAD: fcb6a29) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/379094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from xie cui:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/379094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Katie Hockman:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/379094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 9a86d5b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/379094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Katie Hockman:

Patch Set 5: Run-TryBot+1 Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/379094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/379094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/379094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/379094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 57ff5dd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/379094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from xie cui:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/379094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from xie cui:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/379094.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 18, 2022
@cuiweixie @ianlancetaylor
crypto/x509: return err ans1.Marshal gives an error
3ea22cf 
Fixes #50663

Change-Id: I18754922bf139049443c0395eaa1606049df1331
GitHub-Last-Rev: 57ff5dd
GitHub-Pull-Request: #50667
Reviewed-on: https://go-review.googlesource.com/c/go/+/379094
Reviewed-by: Katie Hockman <katie@golang.org>
Trust: Katie Hockman <katie@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/379094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 6: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/379094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/379094 has been merged.

@gopherbot gopherbot closed this Mar 18, 2022
bassosimone pushed a commit to ooni/oocrypto that referenced this pull request Aug 18, 2022
@cuiweixie @ianlancetaylor
crypto/x509: return err ans1.Marshal gives an error
f072015 
Fixes #50663

Change-Id: I18754922bf139049443c0395eaa1606049df1331
GitHub-Last-Rev: 57ff5ddfe39c211ccff60aa74a30f97ddf7015fb
GitHub-Pull-Request: golang/go#50667
Reviewed-on: https://go-review.googlesource.com/c/go/+/379094
Reviewed-by: Katie Hockman <katie@golang.org>
Trust: Katie Hockman <katie@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x509: marshalBasicConstraints should return error in case of marshalling error
2 participants
@cuiweixie @gopherbot