x/tools/gopls: replace refactoring code actions Command with Edits and codeAction/resolve #64510
Assignees
Labels
gopls
Issues related to the Go language server, gopls.
Refactoring
Issues related to refactoring tools
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
gopherbot
added
the
Tools
|
Change https://go.dev/cl/548276 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Jan 18, 2024
Allow apply fix and change signature commands to return edits instead of applying the edits. Added a marker test for removing parameters using the new resolve logic. We probably want most refactoring code actions to work both ways. This also updates the fill struct test to make sure that the capabilities of the editor are being correctly respected. For golang/go#64510 Change-Id: If58f7bdff52ec8e1621c007d029c5b9b60bbdd3a Reviewed-on: https://go-review.googlesource.com/c/tools/+/548276 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Alan Donovan <adonovan@google.com>
|
Change https://go.dev/cl/562118 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Feb 9, 2024
Resolve edits for inline refactorings when the client supports it. For golang/go#64510 Change-Id: I67101ab19576054b1d03c46e3d318a4660088a63 Reviewed-on: https://go-review.googlesource.com/c/tools/+/562118 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Alan Donovan <adonovan@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
codeAction/resolve was introduced to LSP in 3.16. This allows code action requests to omit
Editsfor a code action and compute them when necessary.Currently, gopls implements this lazy computation by passing a command to the codeAction. However, if the client supports it we can use
codeAction/resolveinstead. This will enable code action previews in VS Code.Client support is registered through textDocument.codeAction.resolveSupport:
gopls already has ResolveCodeAction
The text was updated successfully, but these errors were encountered: