Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow refactorings to be previewed #151140

Closed
mjbvz opened this issue Jun 2, 2022 · 2 comments · Fixed by #151566
Closed

Allow refactorings to be previewed #151140

mjbvz opened this issue Jun 2, 2022 · 2 comments · Fixed by #151566
Assignees
@justschen
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone
June 2022

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 2, 2022

Feature request

When refactoring, it should be possible to preview the refactoring in the refactor menu, similar to how we support previews of renames
@mjbvz mjbvz added this to the June 2022 milestone Jun 2, 2022
@mjbvz mjbvz assigned mjbvz and justschen and unassigned mjbvz Jun 2, 2022
This was referenced Jun 8, 2022
Closed
Merged
@mjbvz mjbvz added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Jun 9, 2022
justschen added a commit that referenced this issue Jun 9, 2022
@justschen
Merge pull request #151566 from justschen/justin/refactor-fix
a38448d 
Refactoring Preview option in Command Palette (part of #151140)
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 9, 2022
@justschen
Copy link
Contributor

justschen commented Jun 9, 2022 •
edited
Loading

Added an additional command in the command palette that allows users to "Refactor with preview" - viewing refactorings in the refactor preview terminal instead of immediately applying refactor changes.

Normal Refactor flow:
Recording 2022-06-09 at 11 48 57

Refactor with Preview (similar to the renaming preview):
Recording 2022-06-09 at 11 48 22

Moving forward, we'll be modifying the refactoring menu and potentially adding additional refactoring preview options.

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 10, 2022
@justschen justschen mentioned this issue Jun 14, 2022
Merged
@kieferrm kieferrm mentioned this issue Jun 16, 2022
Closed
99 tasks
@justschen justschen mentioned this issue Jun 16, 2022
Merged
@justschen justschen mentioned this issue Jun 27, 2022
Closed
3 tasks
@jrieken jrieken mentioned this issue Jun 28, 2022
Closed
@jrieken jrieken added the verified Verification succeeded label Jun 28, 2022
@sandy081
Copy link
Member

This item is both in test plan and to be verified features list.

@jrieken Since you verified this, I will add you to the testers list of the associated TPI so that we can see the coverage.

@sandy081 sandy081 added on-testplan and removed verification-needed Verification of issue is requested verified Verification succeeded labels Jun 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@justschen justschen

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Milestone
June 2022
5 participants
@jrieken @sandy081 @mjbvz @justschen @VSCodeTriageBot