Added Telemetry for CodeActions (part of refactoring preview) #152081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
requested changes
Jun 14, 2022
| }; | ||
| type ApplyCodeEventClassification = { | ||
| codeActionTitle: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The display label of the applied code action' }; | ||
| codeActionKind: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The kind (refactor, quickfix) of the applied code action' }; | ||
| codeActionIsPreferred: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Was the code action marked as being a preferred action?' }; | ||
| context?: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The kind of action used to trigger apply code action.' }; |
There was a problem hiding this comment.
context is pretty generic. Maybe reason?
| } | ||
| } | ||
|
|
||
| export enum applyCodeActionReason { |
There was a problem hiding this comment.
[nit] We typically start enum names with uppercase
| export async function applyCodeAction( | ||
| accessor: ServicesAccessor, | ||
| item: CodeActionItem, | ||
| options?: { preview?: boolean; editor?: ICodeEditor } | ||
| options?: { preview?: boolean; editor?: ICodeEditor }, | ||
| codeActionReason?: applyCodeActionReason, |
There was a problem hiding this comment.
If anyone starts calling this function, it will be easy for them to forget to pass in a codeActionReason. Can you make this parameter non-optional (you'll have to either change the order of the parameters or make options non-optional too for this)
mjbvz
approved these changes
Jun 14, 2022
justschen
added a commit
to justschen/vscode
that referenced
this pull request
Jun 16, 2022
…Telemetry Added Telemetry for CodeActions (part of refactoring preview)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #151140