Adding additional telemetry on CodeActions #152383
Conversation
…Telemetry Added Telemetry for CodeActions (part of refactoring preview)
Support persisting the environment variable collection each terminal was created with
Mention history in terminal persistence settings
Profile support for global storage
|
Results from telemetry look like this. From lightbulb, where user cancelled selection: From refactor, where user selected an action, and applyCodeAction was called: |
|
also currently having this issue - leads to compilation, unit, and integration tests to fail |
| }; | ||
|
|
||
| this._telemetryService.publicLog2<ApplyCodeActionEvent, ApplyCodeEventClassification>('codeAction.applyCodeAction', { | ||
| codeActionFrom: <CodeMenuOpenedFrom>openedFromString, |
There was a problem hiding this comment.
You should not need the cast here
There was a problem hiding this comment.
Left the casting for now - not sure how I could set defaults from the interface (since there were a LOT of times where CodeActionTrigger were being called)
There was a problem hiding this comment.
This is because openedFromString is CodeMenuOpenedFrom | undefined. The cast is hiding an error here because we are always expecting a value, not undefined
| @@ -123,6 +136,7 @@ export interface CodeActionTrigger { | |||
| readonly position: Position; | |||
| }; | |||
| readonly preview?: boolean; | |||
| readonly triggerAction?: CodeMenuOpenedFrom; | |||
There was a problem hiding this comment.
I think you should make this required. I just tested this and while it does cause a lot of compile errors, it also reveals cases that should have a triggerAction passed in
| }; | ||
|
|
||
| this._telemetryService.publicLog2<ApplyCodeActionEvent, ApplyCodeEventClassification>('codeAction.applyCodeAction', { | ||
| codeActionFrom: <CodeMenuOpenedFrom>openedFromString, |
There was a problem hiding this comment.
This is because openedFromString is CodeMenuOpenedFrom | undefined. The cast is hiding an error here because we are always expecting a value, not undefined
Building on top of PR #152081 for issue #151140 (for code actions telemetry and refactoring)