-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Preview option in Command Palette (part of #151140) #151566
Conversation
…efactor preview will pop up a preview
label: item.action.title, | ||
quotableLabel: item.action.title, | ||
code: 'undoredo.codeAction', | ||
respectAutoSaveConfig: true | ||
respectAutoSaveConfig: true, | ||
showPreview: options?.showPreviewPane, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] Potentially align these names: showPreview
vs showPreviewPane
vs preview
onSelectCodeAction: async (action) => { | ||
this.delegate.applyCodeAction(action, /* retrigger */ true); | ||
onSelectCodeAction: async (action, trigger) => { | ||
if (trigger.preview !== undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may be incorrect as we always want to apply the refactoring . Instead try using Boolean(trigger.preview)
to convert trigger.preview
to a boolean
This PR fixes #151140