Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: add telemetry counters that will help with the v0.17.0 release #68240

Closed
findleyr opened this issue Jun 28, 2024 · 2 comments
Closed

x/tools/gopls: add telemetry counters that will help with the v0.17.0 release #68240

findleyr opened this issue Jun 28, 2024 · 2 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.1

Comments

@findleyr
Copy link
Contributor

findleyr commented Jun 28, 2024 •
edited
Loading

In the v0.17.0 release, we are planning a couple decisions that could benefit from more information:

We should add telemetry to gopls@v0.16.1 that can help us plan for these changes:

  • Keep track of when people accept the telemetry prompt. This will provide signal for what fraction of users opting in to telemetry are doing so as a result of the IDE prompt. (of course we can't keep track of when people don't accept the prompt!)
  • Record whether users are setting GOTOOLCHAIN=auto, GOTOOLCHAIN=local, and GOTOOLCHAIN=. That will provide signal for what fraction of users may not have toolchain upgrades available.

EDIT: since this is mentioned in the gopls@v0.16.1 released notes, I wanted to note the following:

  • This issue is for local instrumentation only.
  • Collection of this data will be filed as a separate public proposal.
  • This only affects users who have opted in to sharing telemetry data.
@findleyr findleyr added this to the gopls/v0.16.1 milestone Jun 28, 2024
@findleyr findleyr self-assigned this Jun 28, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 28, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/595560 mentions this issue: gopls/internal/server: add counters to inform v0.17.0

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/595836 mentions this issue: [gopls-release-branch.0.16] gopls/internal/server: add counters to inform v0.17.0

gopherbot pushed a commit to golang/tools that referenced this issue Jun 28, 2024
@findleyr @gopherbot
[gopls-release-branch.0.16] gopls/internal/server: add counters to in…
9c895dd 
…form v0.17.0

Add two counters to help inform decisions for gopls@v0.17.0:

- Add a gopls/gotoolchain:{auto,local,other} counter to help us
  understand toolchain upgradability.
- Add a gopls/telemetryprompt/accepted counter to track telemetry prompt
  acceptance.

Fixes golang/go#68240

Change-Id: I8fc06b3a266761dbf7c2781267dfb1235eef1a63
Reviewed-on: https://go-review.googlesource.com/c/tools/+/595560
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
(cherry picked from commit fcf5463)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/595836
Auto-Submit: Robert Findley <rfindley@google.com>
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jul 7, 2024
@0-wiz-0
gopls: update to 0.16.1.
d63d830 
This release addresses the following gopls issues:

    golang/go#68116, broken links to dependencies in the new integrated doc viewer.
    golang/go#68169, a crash in package name completion.
    golang/go#68213, a crash when hovering over an interface with an empty type set.
    golang/go#68240, additional telemetry instrumentation to help inform decisions for gopls@v0.17.0. (Note that this is local instrumentation only; a separate proposal will be filed to allow collection of this data from users who have opted in to sharing their telemetry data).
This was referenced Aug 7, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.16.1
Development

No branches or pull requests
2 participants
@gopherbot @findleyr