Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: package not found when "linksInHover": "gopls" #68116

Closed
freeformz opened this issue Jun 21, 2024 · 7 comments
Closed

x/tools/gopls: package not found when "linksInHover": "gopls" #68116

freeformz opened this issue Jun 21, 2024 · 7 comments
Assignees
@adonovan
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.1

Comments

@freeformz
Copy link

freeformz commented Jun 21, 2024 •
edited
Loading

ATTENTION: Please answer these questions BEFORE submitting your issue. Thanks!

I am not sure if this is a gopls issue of vs-code go extension issue ... or both...

What did you do?

Enabled

  "gopls": {
    "ui.documentation.linksInHover": "gopls"
  },

Clicked on a doc link in the hover popup for grpc.DialContext and it took me to...
http://127.0.0.1:53693/gopls/exMLWbr5ON4/pkg/google.golang.org/grpc@v1.62.1?view=1#DialContext
And that returned package not found
Screenshot 2024-06-21 at 3 45 28 PM

Right clicked -> Source Action -> Browse documentation for func grpc.DialContext -> which opened http://127.0.0.1:53693/gopls/exMLWbr5ON4/pkg/google.golang.org/grpc?view=1#DialContext (note the difference in the urls)

Screenshot 2024-06-21 at 3 55 44 PM

I tried this in multiple projects and different symbols with the same results (hover popup doc link returns package not found / Source Action works)

What did you expect to see?

The documentation for grpc.DialContext from gopls

What did you see instead?

package not found

Build info

golang.org/x/tools/gopls v0.16.0
    golang.org/x/tools/gopls@v0.16.0 h1:JOYR1NabC699+pLFI02CxlD9xaPXdaVmPp7f01k0/hE=
    github.com/BurntSushi/toml@v1.2.1 h1:9F2/+DoOYIOksmaJFPw1tGFy1eDnIJXg+UHjuD8lTak=
    github.com/google/go-cmp@v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
    golang.org/x/exp/typeparams@v0.0.0-20221212164502-fae10dda9338 h1:2O2DON6y3XMJiQRAS1UWU+54aec2uopH3x7MAiqGW6Y=
    golang.org/x/mod@v0.18.0 h1:5+9lSbEzPSdWkH32vYPBwEpX8KwDbM52Ud9xBUvNlb0=
    golang.org/x/sync@v0.7.0 h1:YsImfSBoP9QPYL0xyKJPq0gcaJdG3rInoqxTWbfQu9M=
    golang.org/x/telemetry@v0.0.0-20240607193123-221703e18637 h1:3Wt8mZlbFwG8llny+t18kh7AXxyWePFycXMuVdHxnyM=
    golang.org/x/text@v0.16.0 h1:a94ExnEXNtEwYLGJSIUxnWoxoRz/ZcCsV63ROupILh4=
    golang.org/x/tools@v0.22.1-0.20240620150659-cb3016b76f3e h1:Cht5EwNRmW9EgQ7ihPmgIswaQW4jR1cPbmzGCNl2++8=
    golang.org/x/vuln@v1.0.4 h1:SP0mPeg2PmGCu03V+61EcQiOjmpri2XijexKdzv8Z1I=
    honnef.co/go/tools@v0.4.7 h1:9MDAWxMoSnB6QoSqiVr7P5mtkT9pOc1kSxchzPCnqJs=
    mvdan.cc/gofumpt@v0.6.0 h1:G3QvahNDmpD+Aek/bNOLrFR2XC6ZAdo62dZu65gmwGo=
    mvdan.cc/xurls/v2@v2.5.0 h1:lyBNOm8Wo71UknhUs4QTFUNNMyxy2JEIaKKo0RWOh+8=
go: go1.22.2
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 21, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jun 21, 2024
@gabyhelp
Copy link

Similar Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@freeformz freeformz changed the title x/tools/gopls: <DESCRIBE THE PROBLEM> x/tools/gopls: package not found when linksInHover": "gopls" Jun 21, 2024
@freeformz freeformz changed the title x/tools/gopls: package not found when linksInHover": "gopls" x/tools/gopls: package not found when "linksInHover": "gopls" Jun 21, 2024
@ansaba ansaba added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 24, 2024
@freeformz
Copy link
Author

Another engineer at $WORK was able to reproduce, although not consistently.

@findleyr
Copy link
Contributor

CC @adonovan

@adonovan
Copy link
Member

I can reproduce this in gopls' own main.go file on the telemetry.Start symbol. Wow, I can't believe I missed a bug this
shallow during all the testing. Thanks for reporting.

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.16.1 Jun 24, 2024
@adonovan adonovan self-assigned this Jun 24, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/594556 mentions this issue: gopls/internal/golang: strip @v1.2.3 suffix from pkgdoc URLs

@freeformz
Copy link
Author

I installed from master and am having a similar problem.

From doc link in the hover popup: (URL: http://127.0.0.1:63774/gopls/on0HKAhym30/pkg/github.com/google/flatbuffers?view=1#Builder)

Screenshot 2024-06-27 at 9 31 29 AM

From the Source Action: (URL: http://127.0.0.1:63774/gopls/on0HKAhym30/pkg/github.com/google/flatbuffers/go?view=1#Builder
Screenshot 2024-06-27 at 9 33 06 AM

Note the difference in the URLS....

http://127.0.0.1:63774/gopls/on0HKAhym30/pkg/github.com/google/flatbuffers?view=1#Builder
http://127.0.0.1:63774/gopls/on0HKAhym30/pkg/github.com/google/flatbuffers/go?view=1#Builder

The first one doesn't work, the second one does.

@freeformz freeformz mentioned this issue Jun 27, 2024
Open
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/595563 mentions this issue: [gopls-release-branch.0.16] gopls/internal/golang: strip @v1.2.3 suffix from pkgdoc URLs

gopherbot pushed a commit to golang/tools that referenced this issue Jun 28, 2024
@adonovan @gopherbot
[gopls-release-branch.0.16] gopls/internal/golang: strip @v1.2.3 suff…
76e6044 
…ix from pkgdoc URLs

The  package path in a /pkg URL does not want a module
version suffix: the view specifies the versions of all packages.
Remove them.

Fixes golang/go#68116

Change-Id: Icbe7a6e7346d12456724d005fe8f755872657055
Reviewed-on: https://go-review.googlesource.com/c/tools/+/594556
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
(cherry picked from commit 1e6c1e2)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/595563
Auto-Submit: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jul 7, 2024
gopls: update to 0.16.1.
d63d830 
This release addresses the following gopls issues:

    golang/go#68116, broken links to dependencies in the new integrated doc viewer.
    golang/go#68169, a crash in package name completion.
    golang/go#68213, a crash when hovering over an interface with an empty type set.
    golang/go#68240, additional telemetry instrumentation to help inform decisions for gopls@v0.17.0. (Note that this is local instrumentation only; a separate proposal will be filed to allow collection of this data from users who have opted in to sharing their telemetry data).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.16.1
Development

No branches or pull requests
6 participants
@freeformz @ansaba @adonovan @gopherbot @findleyr @gabyhelp