Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: add 1.23 and tip builders with GODEBUG=gotypesalias=1 for at least the x/tools repo #68798

Closed
findleyr opened this issue Aug 8, 2024 · 7 comments
Closed

x/build: add 1.23 and tip builders with GODEBUG=gotypesalias=1 for at least the x/tools repo #68798

findleyr opened this issue Aug 8, 2024 · 7 comments
Assignees
@timothy-king @dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@findleyr
Copy link
Contributor

findleyr commented Aug 8, 2024

See #68796 and #68797 for some background on missing test coverage with GODEBUG=gotypesalias=1.

Until x/tools has a go.mod file that says 1.23 (not until at least 1.24 is released), it will lack test coverage of GODEBUG=gotypesalias=1. @timothy-king had added go1.21 and go1.22 builders with GODEBUG=gotypesalias=1; we need them for 1.23 and tip as well.

@timothy-king @dmitshur would you mind adding these as well? CC @adonovan
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Aug 8, 2024
@gopherbot gopherbot added this to the Unreleased milestone Aug 8, 2024
@gabyhelp
Copy link

gabyhelp commented Aug 8, 2024

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@findleyr findleyr mentioned this issue Aug 8, 2024
Closed
@dmitshur
Copy link
Contributor

dmitshur commented Aug 8, 2024

These builders were recently updated in CL 601177 to stop existing after 1.22 based on the idea that 1.23 and later already default to GODEBUG=gotypesalias=1. I'll refine that to keep them around for 1.23 and 1.24 as well.

@dmitshur dmitshur moved this to In Progress in Go Release Aug 8, 2024
@findleyr
Copy link
Contributor Author

findleyr commented Aug 8, 2024

Thanks very much @dmitshur! Would it be possible to add the tip builder to the default presubmit tryset as well?

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Aug 8, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/604335 mentions this issue: main.star: enable linux-amd64-typesalias postsubmit for Go 1.23 and tip

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/604336 mentions this issue: main.star: enable linux-amd64-typesalias presubmit for Go 1.23 and tip

@dmitshur dmitshur changed the title x/tools: add 1.23 and tip builders with GODEBUG=gotypesalias=1 x/build: add 1.23 and tip builders with GODEBUG=gotypesalias=1 for at least the x/tools repo Aug 8, 2024
@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Aug 9, 2024
gopherbot pushed a commit to golang/build that referenced this issue Aug 9, 2024
@dmitshur @gopherbot
main.star: enable linux-amd64-typesalias postsubmit for Go 1.23 and tip
9e8a03b 
New information in go.dev/issue/68798 shows that having this builder
available for 1.23 and at tip will be helpful, at least in the short
term. Also run it in postsubmit (for 1.23/tip only, where it's meant
to pass), and also in presubmit as of the next CL.

For golang/go#68798.

Change-Id: I72183cc8703b65ecb265e01b18288651a7e64cfb
Reviewed-on: https://go-review.googlesource.com/c/build/+/604335
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Tim King <taking@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Aug 9, 2024
@dmitshur @gopherbot
main.star: enable linux-amd64-typesalias presubmit for Go 1.23 and tip
8cb2bf7 
This is separated out in a separate CL for a more gradual rollout.

Fixes golang/go#68798.

Change-Id: I6a4c2f1e89ab7c6426a9b5d19e429b68ca61bee4
Reviewed-on: https://go-review.googlesource.com/c/build/+/604336
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Tim King <taking@google.com>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link
Contributor

Closed by merging CL 604336 (commit golang/build@8cb2bf7) to luci-config.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Aug 9, 2024
@DashaBochkar

This comment was marked as duplicate.

Sign in to view
@timothy-king timothy-king mentioned this issue Aug 28, 2024
Closed
@gabyhelp gabyhelp mentioned this issue Oct 3, 2024
Open
@gabyhelp gabyhelp mentioned this issue Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timothy-king timothy-king

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@timothy-king @dmitshur @gopherbot @findleyr @DashaBochkar @gabyhelp