x/build: add tip builders with GOEXPERIMENT=aliastypeparams=1 for at least go and x/tools repo #69121
Assignees
Labels
Milestone
Comments
|
Related Issues and Documentation
(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.) |
|
Change https://go.dev/cl/609375 mentions this issue: |
dmitshur
added
the
NeedsFix
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Aug 29, 2024
For golang/go#69121 Change-Id: Ia3183c1037384ee36b1afe174f70fa9cfda12f86 Reviewed-on: https://go-review.googlesource.com/c/build/+/609375 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
|
Change https://go.dev/cl/609735 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Sep 6, 2024
For golang/go#69121 Change-Id: Ia47ba04ed86cf1785edaddd689c53065f4a83d87 Reviewed-on: https://go-review.googlesource.com/c/build/+/609735 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add a builder for >=1.24 with GOEXPERIMENT=aliastypeparams=1 for additional test coverage (#46477). aliastypeparams was introduced in 1.23. Its default is currently off. For the 1.24 release, we want to flip this to default to on.
For packages that use
go/types, this also requires GODEBUG=gotypesalias=1. This includes x/tools.We do not expect <= 1.23 to fully work with type parameterized aliases. (1.23 only supported these as a 'preview'.) The builders for #68798 (GODEBUG=gotypesalias=1) are enabled at 1.22 and 1.23. So these configurations are not expected to overlap smoothly.
The text was updated successfully, but these errors were encountered: