Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: release version v0.17.0 #70301

Closed
8 tasks done
gopherbot opened this issue Nov 12, 2024 · 15 comments
Closed
8 tasks done

x/tools/gopls: release version v0.17.0 #70301

gopherbot opened this issue Nov 12, 2024 · 15 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.17.0

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Nov 12, 2024 •
edited by findleyr
Loading

This issue tracks progress toward releasing gopls@v0.17.0

  • create or update gopls-release-branch.0.17
  • update go.mod/go.sum (remove x/tools replace, update x/tools version)
  • tag gopls/v0.17.0-pre.1
  • update Github milestone
  • write release notes
  • smoke test features
  • tag gopls/v0.17.0
  • (if vX.Y.0 release): update dependencies in master for the next release
@gopherbot gopherbot added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Nov 12, 2024
@gopherbot gopherbot added this to the gopls/v0.17.0 milestone Nov 12, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/626656 mentions this issue: all: update codereview.cfg for gopls-release-branch.0.17

gopherbot added a commit to golang/tools that referenced this issue Nov 12, 2024
@gopherbot
all: update codereview.cfg for gopls-release-branch.0.17
2b56df4 
This is an automated CL which updates the codereview.cfg.

For golang/go#70301

Change-Id: I4ec94b5070c9e34c631a5112700292edf825f7b9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/626656
Auto-Submit: Gopher Robot <gobot@golang.org>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/626657 mentions this issue: gopls: update go.mod for v0.17.0-pre.1

gopherbot added a commit to golang/tools that referenced this issue Nov 12, 2024
@gopherbot
gopls: update go.mod for v0.17.0-pre.1
3296d74 
This is an automated CL which updates the go.mod and go.sum.

For golang/go#70301

Change-Id: I4d9ef00c940ee1f4f7591b6331629a6f5ab2c3a1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/626657
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
Auto-Submit: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/627995 mentions this issue: all: merge master (5b5d57c) into gopls-release-branch.0.17

gopherbot pushed a commit to golang/tools that referenced this issue Nov 14, 2024
@findleyr
all: merge master (5b5d57c) into gopls-release-branch.0.17
21afbf4 
Merge List:

+ 2024-11-14 5b5d57c gopls/codeaction: fix panic when removing unused parameters with syntax errors.
+ 2024-11-13 025b812 gopls/internal/server: don't call window/showDocument if unsupported
+ 2024-11-13 288b9cb gopls/internal/golang: add missing imports in foo_test.go
+ 2024-11-13 87ac91f gopls/internal/server: revert the gopls.run_govulncheck command
+ 2024-11-12 c531f1b gopls/internal/golang: avoid crash in hover on field of non-struct
+ 2024-11-12 a37eeb4 README: mention the git repo
+ 2024-11-12 8dd84a4 go/ssa/interp: assign phi nodes in parallel

For golang/go#70301

Change-Id: I9b584de0bcbd622a6bcf5f06f34232993ac2f9a4
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/628035 mentions this issue: gopls: update go.mod for v0.17.0-pre.2

gopherbot added a commit to golang/tools that referenced this issue Nov 14, 2024
@gopherbot
gopls: update go.mod for v0.17.0-pre.2
b6cd453 
This is an automated CL which updates the go.mod and go.sum.

For golang/go#70301

Change-Id: Ibf9b0ab5ac4be19833c364722297b73a72273ebb
Reviewed-on: https://go-review.googlesource.com/c/tools/+/628035
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/631676 mentions this issue: all: merge master (68e4702) into gopls-release-branch.0.17

gopherbot pushed a commit to golang/tools that referenced this issue Nov 26, 2024
@findleyr
all: merge master (68e4702) into gopls-release-branch.0.17
3ef0ed3 
Also add back the x/tools replace directive.

For golang/go#70301

Merge List:

+ 2024-11-26 68e4702 go/analysis/passes/printf: add missing call to Func.Origin
+ 2024-11-26 30a3bd9 gopls/internal/golang: refactor.extract.variable: allow all exprs
+ 2024-11-26 0edd1ab gopls/internal/cache/methodsets: refine crash for missing object path
+ 2024-11-25 07a58bc gopls/internal/golang: refine crash golang/go#70553
+ 2024-11-25 c622026 completions/inference: infer polymorphic types in completions
+ 2024-11-25 dcfb0b6 gopls/internal/golang: change signature via renaming 'func'
+ 2024-11-25 bfcbc1b internal/refactor/inline: avoid unnecessary desugaring in selectors
+ 2024-11-25 b93a72a internal/refactor/inline: fix spurious caller mutation
+ 2024-11-25 41f04a0 internal/refactor/inline: fix comment movement due to added imports
+ 2024-11-25 0841661 internal/refactor/inline: avoid unnecessary interface conversions
+ 2024-11-25 68b67b4 gopls/internal/golang: support parameter movement refactorings
+ 2024-11-22 51e54e8 gopls/doc/features: enable and document source.addTest code action
+ 2024-11-22 458067f gopls/internal/golang: improve test package name selection for new file
+ 2024-11-22 68caf84 gopls/internal/golang: don't lose ... when split/joining variadics
+ 2024-11-21 1e0d4ee go/analysis/checker: disable Example on wasm
+ 2024-11-21 8b6e84b gopls/internal/crash: don't crash in xrefs on out of bound nodes
+ 2024-11-21 936a401 gopls/internal/golang: preserve copyright and build constraint
+ 2024-11-21 1ffc3a1 gopls/internal/test/marker: add defloc, to bind positions by definition
+ 2024-11-21 442d6be gopls/internal/test/marker: document named parameters
+ 2024-11-21 ae39b13 go/analysis/checker: a go/packages-based driver library
+ 2024-11-21 c3a6283 go/packages: undeprecate Load* style flags
+ 2024-11-20 9dff42e gopls/internal/golang/extract: preserve comments in extracted block
+ 2024-11-20 8c3ba8c internal/refactor: undo variadic elimination during substitution
+ 2024-11-20 3b0b264 internal/refactor: handle qualified names in inlined assignments
+ 2024-11-20 9311800 gopls/internal/test/marker: ignore diags in fixedbugs/issue59944.txt
+ 2024-11-20 c1aa79d gopls/internal/golang: fix gopls hover doc link
+ 2024-11-20 e751756 internal/analysisinternal: unify zero value function to typesinternal
+ 2024-11-20 a287481 internal/imports: test Source for go mod cache
+ 2024-11-19 9387a39 gopls/doc/contributing.md: update expectations
+ 2024-11-19 e08fcf7 gopls/internal/analysis/undeclaredname: merge into CodeAction
+ 2024-11-18 0c01408 internal/refactor/inline: avoid binding decl for name used by other args
+ 2024-11-18 63e03c3 gopls/internal/test/marker: generalize codeaction with named args
+ 2024-11-18 acc2a74 go/analysis/passes/copylock: enable unfortunate tests
+ 2024-11-18 39cb6f0 internal/facts: use alias type parameters and arguments during imports
+ 2024-11-18 9b9871d go/analysis/passes/copylock: test for noCopy for sync Map, Mutex, Once
+ 2024-11-18 a54bd37 gopls/internal/golang: don't try to inline dynamic calls
+ 2024-11-18 52eb446 internal/imports: adjust TestStdlibSelfImports pkg
+ 2024-11-18 b8ff201 gopls/internal/cache: refine bug reports for inconsistent dep view
+ 2024-11-18 e59fd36 go/ssa: use ZeroString unconditionally
+ 2024-11-18 60bc93d gopls/internal/cache: fix handling of cgo standalone files
+ 2024-11-18 ed19fc7 gopls/internal/test: synchronize notifications during commands
+ 2024-11-15 254baba gopls/internal/cache: failure to extract diagnostic fixes is an error
+ 2024-11-15 56ec111 gopls/internal/server: remove spurious Async in legacy RunGoVulncheck
+ 2024-11-14 b1c39aa gopls/internal/cache: use a named bool type for allowNetwork
+ 2024-11-14 c043599 gopls/internal/protocol: add DocumentURI.DirPath
+ 2024-11-14 29f4edb gopls/internal/cache: simplify usage of snapshot.GoCommandInvocation
+ 2024-11-14 3c20e3f gopls/internal/analysis/yield: analyzer for iterator (yield) mistakes
+ 2024-11-14 221e94d gopls/internal/cache: id command-line-arguments packages using GoFiles
+ 2024-11-14 84e9c33 gopls/internal/golang: more idiomatic result naming in extract
+ 2024-11-14 8bb5da3 gopls/internal/golang: special handling for input context.Context
+ 2024-11-14 b4332e0 gopls/internal/golang, go/ssa: remove unnamed input parameter
+ 2024-11-14 a8d0fa5 go/packages: call testenv.NeedsGoPackages for TestDirAndForTest
+ 2024-11-14 47a5f7d gopls/internal/golang: fix bad slice append in function extraction

Change-Id: I2abfc8fd925da3b4ee5964e1cf32bb7fada0e688
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/631857 mentions this issue: gopls: update go.mod for v0.17.0-pre.3

gopherbot added a commit to golang/tools that referenced this issue Nov 26, 2024
@gopherbot
gopls: update go.mod for v0.17.0-pre.3
c9ad642 
This is an automated CL which updates the go.mod and go.sum.

For golang/go#70301

Change-Id: I0d9836a99dc7a922c605a62f66ae73bcebffa1ed
Reviewed-on: https://go-review.googlesource.com/c/tools/+/631857
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
Auto-Submit: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/633695 mentions this issue: all: merge master (e334696) into gopls-release-branch.0.17

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/633735 mentions this issue: all: merge master (7eebab3) into gopls-release-branch.0.17

gopherbot pushed a commit to golang/tools that referenced this issue Dec 4, 2024
@findleyr
all: merge master (7eebab3) into gopls-release-branch.0.17
1eb875f 
Also add back the x/tools replace directive for gopls.

For golang/go#70301

Merge List:

+ 2024-12-04 7eebab3 gopls/internal/golang: support extract variable at top level
+ 2024-12-04 e334696 gopls/internal/golang: ignore effects for change signature refactoring
+ 2024-12-04 3901733 internal/refactor/inline: substitute groups of dependent arguments
+ 2024-12-03 61b2408 gopls/internal/golang: add "Extract constant" counterpart
+ 2024-12-03 c01eead internal/gcimporter: require binary export data header
+ 2024-12-03 9a04136 gopls/internal/golang/stubmethods: refine crash into bug report
+ 2024-12-03 01e0b05 internal/refactor/inline: fix condition for splice assignment strategy
+ 2024-12-03 557f540 gopls/internal/golang: don't offer to move variadic parameters
+ 2024-12-03 399ee16 internal/gcimporter: update FindExportData to return a non-negative size
+ 2024-12-03 25b0003 internal/refactor/inline: more precise redundant conversion detection
+ 2024-12-03 eb46939 gopls/internal/test/marker: add reproducers for moveparam bug bash bugs
+ 2024-12-03 4296223 gopls/internal/analysis/yield: add comment about dataflow
+ 2024-12-03 7a4f3b0 internal/gcimporter: require archive files
+ 2024-12-02 2f73c61 gopls/internal/golang: avoid crash in lookupDocLinkSymbol
+ 2024-12-02 ef3d603 gopls/internal/golang/completion: fix crash with extra results
+ 2024-12-02 8ffeaba gopls/internal/settings: enable 'waitgroup' analyzer
+ 2024-12-02 4317959 go/analysis/passes/waitgroup: report WaitGroup.Add in goroutine
+ 2024-12-02 72fdfa6 gopls/internal/golang: Disable test generation for generic functions
+ 2024-12-02 b80f1ed gopls/internal/analysis/yield: peephole-optimize phi(false, x)
+ 2024-11-28 e7bd227 gopls/internal/golang: fix folding range for function calls
+ 2024-11-28 e71702b internal/versions: remove constraint.GoVersion wrapper
+ 2024-11-28 c99edec gopls/internal/golang/completion: add alias support for literals
+ 2024-11-27 bfe3046 go/packages: add a unit test for golang/go#70394
+ 2024-11-27 df87831 gopls/internal/undeclaredname: add missing colon when appropriate
+ 2024-11-26 53efd30 gopls/internal/golang: simplify package name collection in add test

Change-Id: I476e80493f61732701784befe2b130ca967b259e
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/633915 mentions this issue: gopls: update go.mod for v0.17.0-pre.4

gopherbot added a commit to golang/tools that referenced this issue Dec 5, 2024
@gopherbot
gopls: update go.mod for v0.17.0-pre.4
8f8dbdc 
This is an automated CL which updates the go.mod and go.sum.

For golang/go#70301

Change-Id: Ib85bc49e388697ea643a0512e877225e48d67714
Reviewed-on: https://go-review.googlesource.com/c/tools/+/633915
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/633935 mentions this issue: extension: update gopls v0.17.0-pre.4 settings

gopherbot added a commit to golang/vscode-go that referenced this issue Dec 5, 2024
@gopherbot
extension: update gopls v0.17.0-pre.4 settings
a40e797 
This is an automated CL which updates the gopls version and settings.

For golang/go#70301

Change-Id: I8d61814996c67ff6af8b782cfdc72eb7db3edc29
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/633935
Commit-Queue: Gopher Robot <gobot@golang.org>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/633376 mentions this issue: gopls/doc: update relnotes for v0.17.0

gopherbot pushed a commit to golang/tools that referenced this issue Dec 6, 2024
@findleyr
gopls/doc: update relnotes for v0.17.0
b7532e6 
Update release notes and feature documentation for change signature
refactoring and support changes.

For golang/go#70301

Change-Id: I1a4543e317f1016cdd5631640307b60435f1b23e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/633376
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/635235 mentions this issue: gopls: update go.mod for v0.17.0-pre.5

gopherbot added a commit to golang/tools that referenced this issue Dec 11, 2024
@gopherbot
gopls: update go.mod for v0.17.0-pre.5
688577c 
This is an automated CL which updates the go.mod and go.sum.

For golang/go#70301

Change-Id: I2dc875c08d637f182583c663072ce11ad8230420
Reviewed-on: https://go-review.googlesource.com/c/tools/+/635235
Auto-Submit: Gopher Robot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/635795 mentions this issue: extension: update gopls v0.17.0 settings

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/635796 mentions this issue: gopls/go.mod: update dependencies following the v0.17.0 release

gopherbot added a commit to golang/vscode-go that referenced this issue Dec 12, 2024
@gopherbot
extension: update gopls v0.17.0 settings
800cdac 
This is an automated CL which updates the gopls version and settings.

For golang/go#70301

Change-Id: I9527681e678d6371abcca2278229a6b23ffdfe49
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/635795
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Gopher Robot <gobot@golang.org>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Commit-Queue: Gopher Robot <gobot@golang.org>
gopherbot added a commit to golang/tools that referenced this issue Dec 13, 2024
@gopherbot
gopls/go.mod: update dependencies following the v0.17.0 release
7bfb27f 
This is an automated CL which updates the go.mod and go.sum.

For golang/go#70301

Change-Id: Icadac268ef770a5551cddda3741ee169deb8c3f0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/635796
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/636535 mentions this issue: [release-v0.44] extension: update gopls v0.17.0 settings

gopherbot added a commit to golang/vscode-go that referenced this issue Dec 16, 2024
@gopherbot
[release-v0.44] extension: update gopls v0.17.0 settings
eb7fef4 
This is an automated CL which updates the gopls version and settings.

For golang/go#70301

Change-Id: I9527681e678d6371abcca2278229a6b23ffdfe49
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/635795
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Gopher Robot <gobot@golang.org>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Commit-Queue: Gopher Robot <gobot@golang.org>
(cherry picked from commit 800cdac)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/636535
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.17.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr