x/net/html: add Node.{Ancestors,ChildNodes,Descendants}() #215

earthboundkid · 2024-06-22T19:00:47Z

Adds iterators for the parents, immediate children, and all children of a Node respectively.

google-cla · 2024-06-22T19:00:51Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot · 2024-06-22T19:31:54Z

This PR (HEAD: 4268847) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/594195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-06-22T19:38:02Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-22T20:15:47Z

This PR (HEAD: 347f461) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/594195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-07-25T13:18:34Z

This PR (HEAD: 72158c5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/594195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-07-25T13:25:57Z

This PR (HEAD: 16a697a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/594195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-07-25T13:33:25Z

This PR (HEAD: 4219476) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/594195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-19T17:47:05Z

Message from Damien Neil:

Patch Set 6:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-29T01:19:49Z

This PR (HEAD: 5bfe080) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/594195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-29T01:27:22Z

This PR (HEAD: d83f464) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/594195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-29T01:33:47Z

Message from Carlana Johnson:

Patch Set 7:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-29T01:33:51Z

This PR (HEAD: baf2028) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/594195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-29T14:56:32Z

This PR (HEAD: 13d7555) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/594195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-29T15:18:36Z

Message from Carlana Johnson:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-28T19:38:33Z

Message from Damien Neil:

Patch Set 11: Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-28T19:45:49Z

Message from Go LUCI:

Patch Set 11:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-28T19:32:48Z","revision":"056c531159fb29901264135c5ced7d37e8ca919c"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-28T19:45:49Z

Message from Damien Neil:

Patch Set 11: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-28T19:45:49Z

Message from Go LUCI:

Patch Set 11:

This CL has failed the run. Reason:

Tryjob golang/try/x_net-gotip-linux-amd64 has failed with summary (view all results):

go on master (commit 201b9f6)
net on master (change 594195)

Build or test failure, click here for results.

To reproduce, try gomote repro 8732806269200166881.

Additional links for debugging:

Output for test golang.org/x/net module

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-28T19:45:50Z

Message from Go LUCI:

Patch Set 11: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-28T19:45:50Z

Message from Damien Neil:

Patch Set 12: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-28T19:45:51Z

Message from Go LUCI:

Patch Set 12:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-28T19:34:48Z","revision":"933f6a34cdc5c778d7130f0c1cbef95e7fdc92e2"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-28T19:53:06Z

Message from Damien Neil:

Patch Set 12: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-28T19:53:07Z

Message from Go LUCI:

Patch Set 12:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-28T19:53:07Z

Message from Go LUCI:

Patch Set 12: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

Fixes #62113

Incorporates https://go-review.googlesource.com/c/net/+/606595

gopherbot · 2024-10-28T20:15:42Z

Message from Carlana Johnson:

Patch Set 12:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-28T20:15:48Z

This PR (HEAD: bb50757) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/594195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-28T20:51:56Z

Message from Ian Lance Taylor:

Patch Set 13:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-29T01:29:39Z

This PR (HEAD: d99de58) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/594195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-29T01:36:16Z

Message from Carlana Johnson:

Patch Set 14:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-29T04:12:42Z

Message from Ian Lance Taylor:

Patch Set 14: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/594195.
After addressing review feedback, remember to publish your drafts!

Adds iterators for the parents, immediate children, and all children of a Node respectively. Fixes golang/go#62113 Change-Id: Iab015872cc3a20fe5e7cae3bc90b89cba68cc3f8 GitHub-Last-Rev: d99de58 GitHub-Pull-Request: #215 Reviewed-on: https://go-review.googlesource.com/c/net/+/594195 Reviewed-by: Ian Lance Taylor <iant@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Damien Neil <dneil@google.com>

gopherbot · 2024-10-29T04:19:31Z

This PR is being closed because golang.org/cl/594195 has been merged.

earthboundkid force-pushed the cj/iter branch 2 times, most recently from 498c828 to 74b75cf Compare June 22, 2024 19:06

earthboundkid mentioned this pull request Jun 22, 2024

x/net/html: add Node methods Ancestors, ChildNodes, Descendants golang/go#62113

Closed

earthboundkid changed the title ~~x/net/html: add Node.All() and Node.ChildNodes()~~ x/net/html: add Node.All(), Node.ChildNodes(), and Node.Parents() Jun 22, 2024

earthboundkid changed the title ~~x/net/html: add Node.All(), Node.ChildNodes(), and Node.Parents()~~ x/net/html: add Node.Descendants(), Node.Children(), and Node.Ancestors() Aug 29, 2024

earthboundkid changed the title ~~x/net/html: add Node.Descendants(), Node.Children(), and Node.Ancestors()~~ x/net/html: add Node.{Ancestors,Children,Descendants}() Aug 29, 2024

earthboundkid changed the title ~~x/net/html: add Node.{Ancestors,Children,Descendants}()~~ x/net/html: add Node.{Ancestors,ChildNodes,Descendants}() Oct 28, 2024

Carlana Johnson and others added 16 commits October 28, 2024 16:09

x/net/html: add Node.All() and Node.ChildNodes()

37b10a0

Fixes #62113

add Node.Parents

b11ed9a

add warning to Node.Parents

e25f81f

ExampleParse: Use atom.A

9a8f47f

miscellaneous

036f75b

Fix build tag

4eaadbd

Nicer buildChain

3db76ff

Doc: Fix doc comment

1d4925f

Fix another go build

2dbb524

iter: Better reading order

c98fd06

Revert go.mod change

6246224

Make changes based on feedback

239d691

Incorporates https://go-review.googlesource.com/c/net/+/606595

Missed one!

b599def

Bring back the mutant warning

3cbdcf1

Simpler test

ac0b9cf

Rename Children to ChildNodes

bb50757

earthboundkid force-pushed the cj/iter branch from 13d7555 to bb50757 Compare October 28, 2024 20:14

Feedback

d99de58

gopherbot closed this Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/net/html: add Node.{Ancestors,ChildNodes,Descendants}() #215

x/net/html: add Node.{Ancestors,ChildNodes,Descendants}() #215

earthboundkid commented Jun 22, 2024 •

edited

Loading

google-cla bot commented Jun 22, 2024

gopherbot commented Jun 22, 2024

gopherbot commented Jun 22, 2024

gopherbot commented Jun 22, 2024

gopherbot commented Jul 25, 2024

gopherbot commented Jul 25, 2024

gopherbot commented Jul 25, 2024

gopherbot commented Aug 19, 2024

gopherbot commented Aug 29, 2024

gopherbot commented Aug 29, 2024

gopherbot commented Aug 29, 2024

gopherbot commented Aug 29, 2024

gopherbot commented Aug 29, 2024

gopherbot commented Aug 29, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 29, 2024

gopherbot commented Oct 29, 2024

gopherbot commented Oct 29, 2024

gopherbot commented Oct 29, 2024

x/net/html: add Node.{Ancestors,ChildNodes,Descendants}() #215

x/net/html: add Node.{Ancestors,ChildNodes,Descendants}() #215

Conversation

earthboundkid commented Jun 22, 2024 • edited Loading

google-cla bot commented Jun 22, 2024

gopherbot commented Jun 22, 2024

gopherbot commented Jun 22, 2024

gopherbot commented Jun 22, 2024

gopherbot commented Jul 25, 2024

gopherbot commented Jul 25, 2024

gopherbot commented Jul 25, 2024

gopherbot commented Aug 19, 2024

gopherbot commented Aug 29, 2024

gopherbot commented Aug 29, 2024

gopherbot commented Aug 29, 2024

gopherbot commented Aug 29, 2024

gopherbot commented Aug 29, 2024

gopherbot commented Aug 29, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 28, 2024

gopherbot commented Oct 29, 2024

gopherbot commented Oct 29, 2024

gopherbot commented Oct 29, 2024

gopherbot commented Oct 29, 2024

earthboundkid commented Jun 22, 2024 •

edited

Loading