-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gopls/internal/lsp/source/completion: support more postfix completion…
… for map and slice (len, for, forr) Add some new postfix completions (len, for, forr) for map and slice, with additional support for chan type (for). The previous implementation of postfix completion did not support Placeholder, which resulted in a poor user experience. This can be seen in go.dev/issue/59689. This commit also adds support for Placeholder and modifies some existing places where Placeholder should have been used. Fixes golang/go#64037 Fixes golang/go#59689 Change-Id: I8d27e4c965ce1f8a5631dcdbe9242398fa1f8130 GitHub-Last-Rev: d61809f GitHub-Pull-Request: #459 Reviewed-on: https://go-review.googlesource.com/c/tools/+/541277 Reviewed-by: Robert Findley <rfindley@google.com> Auto-Submit: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
- Loading branch information
Showing
4 changed files
with
351 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.