-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gopls/internal/lsp/source/completion: support more postfix completion for map and slice (len, for, forr) #459
gopls/internal/lsp/source/completion: support more postfix completion for map and slice (len, for, forr) #459
Conversation
This PR (HEAD: 6a45dcb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from tricium-prod@appspot.gserviceaccount.com: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
This PR (HEAD: acb9deb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277. Important tips:
|
Message from Kun Yuan: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from tricium-prod@appspot.gserviceaccount.com: Patch Set 3: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Muir Manders: Patch Set 3: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Robert Findley: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Kun Yuan: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
This PR (HEAD: 8801c00) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277. Important tips:
|
Message from tricium-prod@appspot.gserviceaccount.com: Patch Set 4: (24 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
This PR (HEAD: 9d08180) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277. Important tips:
|
Message from Kun Yuan: Patch Set 4: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from tricium-prod@appspot.gserviceaccount.com: Patch Set 5: (24 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Robert Findley: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
This PR (HEAD: 2c0ea0a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277. Important tips:
|
Message from tricium-prod@appspot.gserviceaccount.com: Patch Set 6: (24 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Kun Yuan: Patch Set 6: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Robert Findley: Patch Set 6: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-11-22T15:30:53Z","revision":"b739499259fc90d6e9e4a5f5d8362da778883615"} Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Robert Findley: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Go LUCI: Patch Set 6: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
This PR (HEAD: 71fa497) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277. Important tips:
|
Message from tricium-prod@appspot.gserviceaccount.com: Patch Set 7: (24 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Robert Findley: Patch Set 7: Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-11-29T17:30:41Z","revision":"d46ab09ddf8c0a7f2aff67d12570050a48245db9"} Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Robert Findley: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
This PR (HEAD: bed62f8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277. Important tips:
|
Message from tricium-prod@appspot.gserviceaccount.com: Patch Set 8: (24 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Kun Yuan: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Robert Findley: Patch Set 8: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Go LUCI: Patch Set 8: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-11-30T13:58:44Z","revision":"bf380003fdf7523cb2a1efd745d1ecff4024ec6d"} Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Robert Findley: Patch Set 8: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Go LUCI: Patch Set 8: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Go LUCI: Patch Set 8: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Robert Findley: Patch Set 8: Auto-Submit+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Dmitri Shuralyov: Patch Set 8: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
… for map and slice (len, for, forr) Add some new postfix completions (len, for, forr) for map and slice, with additional support for chan type (for). The previous implementation of postfix completion did not support Placeholder, which resulted in a poor user experience. This can be seen in the issue golang/go#59689. This commit also adds support for Placeholder and modifies some existing places where Placeholder should have been used. Fixes golang/go#64037, golang/go#59689
This PR (HEAD: d61809f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277. Important tips:
|
Message from tricium-prod@appspot.gserviceaccount.com: Patch Set 10: (24 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Kun Yuan: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Robert Findley: Patch Set 10: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Go LUCI: Patch Set 10: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-12-01T03:26:51Z","revision":"230350be81e1dc727bd7735da259b319aa15df9b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
… for map and slice (len, for, forr) Add some new postfix completions (len, for, forr) for map and slice, with additional support for chan type (for). The previous implementation of postfix completion did not support Placeholder, which resulted in a poor user experience. This can be seen in go.dev/issue/59689. This commit also adds support for Placeholder and modifies some existing places where Placeholder should have been used. Fixes golang/go#64037 Fixes golang/go#59689 Change-Id: I8d27e4c965ce1f8a5631dcdbe9242398fa1f8130 GitHub-Last-Rev: d61809f GitHub-Pull-Request: #459 Reviewed-on: https://go-review.googlesource.com/c/tools/+/541277 Reviewed-by: Robert Findley <rfindley@google.com> Auto-Submit: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Message from Robert Findley: Patch Set 10: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Go LUCI: Patch Set 10: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
Message from Go LUCI: Patch Set 10: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/541277. |
This PR is being closed because golang.org/cl/541277 has been merged. |
Add some new postfix completions (len, for, forr) for map and slice,
with additional support for chan type (for). The previous
implementation of postfix completion did not support Placeholder, which
resulted in a poor user experience. This can be seen in go.dev/issue/59689.
This commit also adds support for Placeholder and modifies some existing places
where Placeholder should have been used.
Fixes golang/go#64037
Fixes golang/go#59689