Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: support "console" property in launch.json (RunInTerminal) #124

Closed
ramya-rao-a opened this issue May 28, 2020 · 29 comments
Closed

debug: support "console" property in launch.json (RunInTerminal) #124

ramya-rao-a opened this issue May 28, 2020 · 29 comments
Assignees
Labels
Debug Issues related to the debugging functionality of the extension. FeatureRequest FrozenDueToAge
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented May 28, 2020

From microsoft/vscode-go#843

Please support "console" Property in launch.json, which have "none", "integratedTerminal", "externalTerminal" three Value like python's, and I can debug my go project at outside console and also support standard input.

This feature request has a lot of upvotes microsoft/vscode-go#843, please follow the discussion there for more context and user scenarios where this feature would be relevant

@stamblerre stamblerre changed the title Support "console" property in launch.json debug: support "console" property in launch.json Jun 3, 2020
@stamblerre stamblerre added Debug Issues related to the debugging functionality of the extension. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 3, 2020
@hyangah
Copy link
Contributor

hyangah commented Sep 21, 2020

I managed to prototype this and let vscode launch the headless delve server in the terminal using DAP RunInTerminal request.
I still need to figure out a reliable way to address the race occurred when the debug adapter tries to connect to the headless server. DAP RunInTerminal response sometime arrives before the delve headless server is ready to accept the request. When the connection attempt is made too early, the json-rpc2 seems to be hung silently. Since json-rpc2 is not under active maintenance mode, we may need to consider switching the underlying json rpc package (#113)

cc/ @suzmue @polinasok

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/268461 mentions this issue: src/debugAdapter: implement runInTerminal

@JCzz
Copy link

JCzz commented Dec 1, 2020

Any progress on this?

@polinasok polinasok changed the title debug: support "console" property in launch.json debug: support "console" property in launch.json (RunInTerminal) Jan 21, 2021
@polinasok
Copy link
Contributor

polinasok commented Jan 21, 2021

@hyangah

I managed to prototype this and let vscode launch the headless delve server in the terminal using DAP RunInTerminal request. I still need to figure out a reliable way to address the race occurred when the debug adapter tries to connect to the headless server. DAP RunInTerminal response sometime arrives before the delve headless server is ready to accept the request.

What is the sequence of requests/responses here? Something like this?

[from client to DA] Launch request with console set to terminal
[from DA to client] RunInTerminal request with dlv command
   client starts dlv
[from client to DA] RunInTerminal response
   DA tries tries to connect to dlv, but dlv is not yet responsive

Can you not introduce a delay like we do in the regular adapter:

function connectClient(port: number, host: string) {
// Add a slight delay to avoid issues on Linux with
// Delve failing calls made shortly after connection.
setTimeout(() => {
const client = Client.$create(port, host);
client.connectSocket((err, conn) => {
if (err) {
return reject(err);
}
return resolve(conn);
});
client.on('error', reject);
}, 200);
?

@polinasok
Copy link
Contributor

polinasok commented Jan 21, 2021

The integratedTerminal and externalTerminal modes are powered by RunInTerminal request. This is advertised as the mechanism for debugging applications that "read from an interactive terminal and/or need to control their output on the terminal" (source, source).

For a high level summary, here are the use cases mentioned by the users in relationship to the request for console=*Terminal feature:

  1. debugging with interactive stdin
    Examples: Please support "console" Property in launch.json microsoft/vscode-go#843 (comment), Cannot debug programs which read from STDIN microsoft/vscode-go#219
    Stdin cannot be entered into the Debug console. Hence, there is a need for an interactive terminal where it can be entered instead. Plain dlv makes this possible, but the user must start a dlv --headless server in one terminal (this is where stdin will go) and a client with dlv connect in another terminal (this is where debug commands will go). Hence, the workaround (mentioned at Please support "console" Property in launch.json microsoft/vscode-go#843 (comment) and Please support "console" Property in launch.json microsoft/vscode-go#843 (comment)) is to launch a headless dlv server in a terminal manually and then use remote attach in vscode to connect to it.
  2. debugging interactive applications
    Examples: Please support "console" Property in launch.json microsoft/vscode-go#843 (comment), Simple ui debugging - not working #863, Unable to debug terminal user interface microsoft/vscode-go#2151
    A workaround (mentioned in Please support "console" Property in launch.json microsoft/vscode-go#843 (comment)) involves starting the application in a terminal and then using local attach.
  3. redirecting output
    Examples: Debugger output and application stdout have to be splitted microsoft/vscode-go#2204
    In case of launch or local attach, dlv is started from the debug adapter, so its output is mixed with the logging and error messages from the adapter in Debug Console. Similarly to 1, a workaround to separate these is to start dlv manually in a separate terminal and then connect to it with remote attach from vscode. In that case dlv's and launched program output would end up in the terminal and not in Debug Console.
  4. running delve with root priviledges
    Examples: debug: abiltiy to debug with root privileges #558, debug the golang project use root privilege microsoft/vscode-go#2889

Of course, the workarounds do not offer a great user experience. But in the absence of the console option, the users are asking if we could offer some shortcuts for these workarounds via the extra extension settings and features. In the meantime, dlv added new options that look related --allow-non-terminal-interactive, --tty, -r (https://github.com/go-delve/delve/blob/master/Documentation/usage/dlv_redirect.md).

@gopherbot gopherbot added this to the Untriaged milestone Apr 8, 2021
@hyangah hyangah modified the milestones: Untriaged, Backlog Apr 14, 2021
hyangah added a commit to hyangah/delve that referenced this issue Jul 2, 2021
This PR adds support for reverse requests that are
sent from the debug adapter to the client. Currently,
RunInTerminal is the only such reverse request.

This is a pre-work for the 'console' support
(golang/vscode-go#124) - we plan to use RunInTerminal
to ask the editor to run a command in the integrated or
external terminal while handling a launch request
with the console attribute.

Launch request was classified as a synchronous request
and was blocking ServeDAPCodec loop, which means the
response message from the client couldn't be read until
onLaunchRequest returns. This PR adds two goroutines -
one to handle requests from the client (loopHandleRequests),
and another to handle responses (loopHandleResponses).
serveDAPCodec will keep read DAP messages from the net.Conn,
but delegate message handling to the goroutines through
buffered channels.

Alternatively, I tried to avoid introducing goroutines
by making onLaunchRequest asynchronously complete the launch
if integrated or external console mode is chosen. I.e.,
make onLaunchRequest return without sending LaunchResponse,
free the ServeDAPCodec loop, and return LaunchResponse (or
ErrorResponse) when RunInTerminal response is received.
But it was hard to follow, didn't look like a typical
go program, and wasn't extensible when DAP adds more
reverse requests or we ever want to utilize RunInTerminal
while handling other requests.

For reverse requests, we maintain a pendingReverseReq map for
requests sent to the client. When response messages arrive
we look up the map, and notify the waiters using a buffered
channel.

onLaunchRequest uses RunInTerminal if the launch request
has "integrated" or "external" console attribute and asks
the client to run a bogus command - this is for testing.
The follow up PRs will implement the real command that
starts a delve and use the command from the integrated
or external terminal.
hyangah added a commit to hyangah/delve that referenced this issue Jul 3, 2021
This PR adds support for reverse requests that are
sent from the debug adapter to the client. Currently,
RunInTerminal is the only such reverse request.

This is a pre-work for the 'console' support
(golang/vscode-go#124) - we plan to use RunInTerminal
to ask the editor to run a command in the integrated or
external terminal while handling a launch request
with the console attribute.

Launch request was classified as a synchronous request
and was blocking ServeDAPCodec loop, which means the
response message from the client couldn't be read until
onLaunchRequest returns. This PR adds two goroutines -
one to handle requests from the client (loopHandleRequests),
and another to handle responses (loopHandleResponses).
serveDAPCodec will keep read DAP messages from the net.Conn,
but delegate message handling to the goroutines through
buffered channels.

Alternatively, I tried to avoid introducing goroutines
by making onLaunchRequest asynchronously complete the launch
if integrated or external console mode is chosen. I.e.,
make onLaunchRequest return without sending LaunchResponse,
free the ServeDAPCodec loop, and return LaunchResponse (or
ErrorResponse) when RunInTerminal response is received.
But it was hard to follow, didn't look like a typical
go program, and wasn't extensible when DAP adds more
reverse requests or we ever want to utilize RunInTerminal
while handling other requests.

For reverse requests, we maintain a pendingReverseReq map for
requests sent to the client. When response messages arrive
we look up the map, and notify the waiters using a buffered
channel.

onLaunchRequest uses RunInTerminal if the launch request
has "integrated" or "external" console attribute and asks
the client to run a bogus command - this is for testing.
The follow up PRs will implement the real command that
starts a delve and use the command from the integrated
or external terminal.
hyangah added a commit to hyangah/delve that referenced this issue Jul 3, 2021
This command is a helper command to be used by dlv dap when
launch request with a console property (integrated, external)
is received. The dlv dap server then asks the client to run
this command in the integrated or external terminal using the
RunInTerminal request and turns itself into a proxy mode that
forwards messages between the client and the dap-reverse command
run by the editor.

The dap-reverse command is similar to the dap command, except
that instead of opening a port and running as a server listening
on the port, this command dials to the supplied address (the
rendezvous port setup by the dlv dap server operating in proxy
mode). Once the dlv-reverse command is connected, the dlv dap
server will forward all the messages from the client (including
the initialize request and the launch request) and relay all
the responses from the dlv-reverse back to the client.

This command is internal use only, so it's intentionally hidden
from users - dlv usage and manual will not display info about
this.

Update golang/vscode-go#124
hyangah added a commit to hyangah/delve that referenced this issue Jul 4, 2021
This PR adds support for reverse requests that are
sent from the debug adapter to the client. Currently,
RunInTerminal is the only such reverse request.

This is a pre-work for the 'console' support
(golang/vscode-go#124) - we plan to use RunInTerminal
to ask the editor to run a command in the integrated or
external terminal while handling a launch request
with the console attribute.

Launch request was classified as a synchronous request
and was blocking ServeDAPCodec loop, which means the
response message from the client couldn't be read until
onLaunchRequest returns. This PR adds two goroutines -
one to handle requests from the client (loopHandleRequests),
and another to handle responses (loopHandleResponses).
serveDAPCodec will keep read DAP messages from the net.Conn,
but delegate message handling to the goroutines through
buffered channels.

Alternatively, I tried to avoid introducing goroutines
by making onLaunchRequest asynchronously complete the launch
if integrated or external console mode is chosen. I.e.,
make onLaunchRequest return without sending LaunchResponse,
free the ServeDAPCodec loop, and return LaunchResponse (or
ErrorResponse) when RunInTerminal response is received.
But it was hard to follow, didn't look like a typical
go program, and wasn't extensible when DAP adds more
reverse requests or we ever want to utilize RunInTerminal
while handling other requests.

For reverse requests, we maintain a pendingReverseReq map for
requests sent to the client. When response messages arrive
we look up the map, and notify the waiters using a buffered
channel.

onLaunchRequest uses RunInTerminal if the launch request
has "integrated" or "external" console attribute and asks
the client to run a bogus command - this is for testing.
The follow up PRs will implement the real command that
starts a delve and use the command from the integrated
or external terminal.
hyangah added a commit to hyangah/delve that referenced this issue Jul 4, 2021
This command is a helper command to be used by dlv dap when
launch request with a console property (integrated, external)
is received. The dlv dap server then asks the client to run
this command in the integrated or external terminal using the
RunInTerminal request and turns itself into a proxy mode that
forwards messages between the client and the dap-reverse command
run by the editor.

The dap-reverse command is similar to the dap command, except
that instead of opening a port and running as a server listening
on the port, this command dials to the supplied address (the
rendezvous port setup by the dlv dap server operating in proxy
mode). Once the dlv-reverse command is connected, the dlv dap
server will forward all the messages from the client (including
the initialize request and the launch request) and relay all
the responses from the dlv-reverse back to the client.

This command is internal use only, so it's intentionally hidden
from users - dlv usage and manual will not display info about
this.

Update golang/vscode-go#124
hyangah added a commit to hyangah/delve that referenced this issue Jul 9, 2021
This PR adds support for reverse requests that are
sent from the debug adapter to the client. Currently,
RunInTerminal is the only such reverse request.

This is a pre-work for the 'console' support
(golang/vscode-go#124) - we plan to use RunInTerminal
to ask the editor to run a command in the integrated or
external terminal while handling a launch request
with the console attribute.

Launch request was classified as a synchronous request
and was blocking ServeDAPCodec loop, which means the
response message from the client couldn't be read until
onLaunchRequest returns. This PR adds two goroutines -
one to handle requests from the client (loopHandleRequests),
and another to handle responses (loopHandleResponses).
serveDAPCodec will keep read DAP messages from the net.Conn,
but delegate message handling to the goroutines through
buffered channels.

Alternatively, I tried to avoid introducing goroutines
by making onLaunchRequest asynchronously complete the launch
if integrated or external console mode is chosen. I.e.,
make onLaunchRequest return without sending LaunchResponse,
free the ServeDAPCodec loop, and return LaunchResponse (or
ErrorResponse) when RunInTerminal response is received.
But it was hard to follow, didn't look like a typical
go program, and wasn't extensible when DAP adds more
reverse requests or we ever want to utilize RunInTerminal
while handling other requests.

For reverse requests, we maintain a pendingReverseReq map for
requests sent to the client. When response messages arrive
we look up the map, and notify the waiters using a buffered
channel.

onLaunchRequest uses RunInTerminal if the launch request
has "integrated" or "external" console attribute and asks
the client to run a bogus command - this is for testing.
The follow up PRs will implement the real command that
starts a delve and use the command from the integrated
or external terminal.
@hickersonj
Copy link

@asilverman this works for me as far as auto launching dlv dap, but I did have to update the tasks.json label value to match the preLaunchTask value.

I get a warning about no problem matcher being defined. Do you have a separate $go problemMatcher? Not sure how to quell that warning or if it matters.
Screen Shot 2021-12-23 at 1 13 56 PM

gopherbot pushed a commit that referenced this issue Dec 29, 2021
Still we don't use RunInTerminal yet.

Run all debug tests with `console: "integrated"` setting.
If tests are too expensive, I will consider to run only a subset of
debug tests with the `console` property.

Updates #124

Change-Id: Iefa48efda2a051795d5462c7f1a81d43a8155e91
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/358516
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
gopherbot pushed a commit that referenced this issue Dec 29, 2021
Do not start dlv-dap until we receive a message from the client
and have to send a message to the dlv-dap. This is because we want
to start dlv dap through RunInTerminal for console:integrated/external
and we cannot know whether client-side session setup (including
handling RunInTerminal request) is ready until the first message
from the client (i.e. the `initialize` request) arrives.

Updates #124

Change-Id: Ia9ce375bb07d852f705b0f95eb0ceb380521ef01
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/358536
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
gopherbot pushed a commit that referenced this issue Dec 29, 2021
Implementation is done by taking advantage of VS Code's RunInTerminal
implementation.

Upon receiving a `initializeRequest` with console=integrated/external
request, the thin debug adapter (DelveDAPOutputAdapter) starts a
temporary TCP listener and sends a RunInTerminal request to start the
`dlv dap --client-addr` command from the specified terminal.
The `dlv dap` command will connect to the TCP listener, and then
DelveDAPOutputAdapter starts to forward messages between VS Code and
the dlv dap process running in the terminal.

Strictly speaking, sending a RunInTerminal request before `initializeResponse`
is incorrect. According to DAP spec:

```
Until the debug adapter has responded to with an ‘initialize’ response, the client must not send any additional requests or events to the debug adapter.

In addition the debug adapter is not allowed to send any requests or events to the client until it has responded with an ‘initialize’ response.
```

More correct ways are either

1) do not depend on RunInTerminal, but directly manage terminals using
vscode terminal APIs, or
  - we cannot utilize the RunInTerminal implementation vscode team
  actively manages and keeps improving.
  - there is no public vscode API for external console mode support
  so we need to implement it from scratch.

2) first respond with an `initialize` response specifying a minimal
capability before sending RunInTerminal request. Once `dlv dap` starts,
forward the stashed `initialize` request to `dlv dap`. When `dlv dap`
returns an `initialize` response, compute the capability difference
and report them as an Capabilities event.
  - add complexity to the DelveDAPOutputDebugAdapter, which
    will no longer be a thin adapter.
  - need significant changes in testing we built using DebugClient.
  - what capabilities changed through Capabilities events are honored
    is also unspeficied in the spec.

3) Delve DAP implements a proper Debug Adapter including reverse
requests. This is the most ideal solution that benefit other DAP-aware
editors.
  - need to agree with delve devs, so may need more time and discussion.

4) ask the vscode team if debug's RunInTerminal capability can be exposed
as a vscode API. If that's possible, we even can do it before the
initialize request and set up this from the factory or tracker.
  - new API. no guarantee if this can be accepted.

Will investigate the possibility of 4 or 1. If not working, we will
work harder to convince delve devs with option 3.

Updates #124

Change-Id: I3d28356a3da99832785815f8af43f7443acf8863
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/358618
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
gopherbot pushed a commit that referenced this issue Jan 5, 2022
When spawning delve, the extension wants to run it in the environment
computed by merging
   1. process.env
   2. go.toolsEnvVars from settings.json
   3. envFile from launch.json
   4. env from launch.json

This is true for both when we use legacy debug adapter and dlv dap
mode.

For some time, we did this environment variable merging from
goDebugConfigurationProvider.

Recently in https://go-review.googlesource.com/c/vscode-go/+/349749,
we changed this logic for dlv dap mode
  - goDebugConfigurationProvider merges only 3 and 4 and stuff the
    result to the launch configuration.
  - from DelveDAPOutputAdapter (thin adapter), we merge 1, 2, and
    the info from the launch configuration (3, 4) and use the result
    when spawning the `dlv dap` process.

We made the change because including 1 and 2 in the launch configuration
resulted in transmitting all the process.env over the wire as launch
parameter unncessarily, and that made users reluctant to share their
debug traces or, made users accidentally share too much info including
sensitive information.

Now with the changes to support the `console` mode, the extension
delegates spawning of `dlv dap` to the VS Code using VS Code's
RunInTerminal implementation. Before this change, we sent environment
variables merging all 1, 2, 3, and 4 as RunInTerminal's env property.
It turned out VS Code's RunInTerminal formulates the final command
to run using the `env` command (in Unix) and lists all the environment
variables. As a result, including process.env (1) in the env property
is problematic:

 - The terminal is crowded and hurts user experience.
 - It may result in a long command and that will suffer from problems
   like microsoft/vscode#134324

Usually, users add only a handful of extra environment variables
in the launch configuration and the go.toolsEnvVars configuration.
And most likely, the terminal will inherit most of the process.env
so we don't need to carry them around.

This change thus skips process.env in RunInTerminal's env property,
but includes only 2, and 3, 4 from goDebugConfigurationProvider.

We still need to merge 1 when the extension spawns 'dlv dap' without
RunInTerminal mode, because Node.JS child_process requires all env
variables should be included.

Updates #124

Change-Id: I33ad5490c6d11a3afb0e569563689be08aefcd06
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/361101
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
gopherbot pushed a commit that referenced this issue Jan 5, 2022
Currently we still clarify that they are "experimental".

Updates #124
Updates #558

Change-Id: I32af4fa0e3cfc73c80bdcdbd22db51c31ccce77c
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/374134
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
gopherbot pushed a commit that referenced this issue Jan 5, 2022
Major language extensions like
vscode-python, vscode-cpptools, vscode-js-debug, vscode-java-debug
all use internalConsole/integratedTerminal/externalTerminal as
accepted values and translate them to RunInTerminal parameters.
Let's follow the convention.

Updates #124

Change-Id: Ie2d3c89487ed05a62d6108e514e985c132140b74
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/374135
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@hyangah
Copy link
Contributor

hyangah commented Jan 5, 2022

The golang.go-nightly released today 2022.1.505 allows users to set console property.
I'd say this is a still experimental feature.

  • uninstall golang.go, install golang.go-nightly and reload window.
  • update dlv to the latest version

Feedback is welcome.

@hyangah hyangah modified the milestones: Unplanned, v0.31.0 Jan 5, 2022
@qmuntal
Copy link

qmuntal commented Jan 13, 2022

The golang.go-nightly released today 2022.1.505 allows users to set console property.
I'd say this is a still experimental feature.

uninstall golang.go, install golang.go-nightly and reload window.
update dlv to the latest version
Feedback is welcome.

@hyangah Great to see progress on this feature! Here is my feedback:

I'm trying to debug using the following config:

==launch.json==

{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Launch Package",
            "type": "go",
            "request": "launch",
            "mode": "auto",
            "program": "${fileDirname}",
            "console": "externalTerminal"
        }
    ]
}

==settings.json==

{
"terminal.external.windowsExec": "cmd.exe /k \"C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\Common7\\Tools\\VsDevCmd.bat\""
}

When launching a debug session the external console appears on the screen but it does not parse the arguments correctly:

'C:\Program' is not recognized as an internal or external command,
operable program or batch file.
Press any key to continue . . .

On the other hand, it works well if I use the integratedTerminal:

==launch.json==

{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Launch Package",
            "type": "go",
            "request": "launch",
            "mode": "auto",
            "program": "${fileDirname}",
            "console": "integratedTerminal"
        }
    ]
}

==settings.json==

{
"terminal.integrated.profiles.windows": {
        "msvc": {
            "path":  ["cmd.exe"],
            "args": [
                "/k",
                "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\Common7\\Tools\\VsDevCmd.bat"
            ]
        }
    },
    "terminal.integrated.defaultProfile.windows": "msvc",
}

@hyangah
Copy link
Contributor

hyangah commented Jan 18, 2022

@qmuntal Many thanks for the feedback. The error message indicates the vscode's request to process the arg and run the batch failed. Even the command requested using DAP runInTerminal wasn't tried. I think this is the same issue as microsoft/vscode#57452

@birgersp
Copy link

The golang.go-nightly released today 2022.1.505 allows users to set console property. I'd say this is a still experimental feature.

  • uninstall golang.go, install golang.go-nightly and reload window.
  • update dlv to the latest version

Feedback is welcome.

I'm using this property for a project, and it's a lifesaver. Great stuff!

@qmuntal
Copy link

qmuntal commented Jan 20, 2022

@qmuntal Many thanks for the feedback. The error message indicates the vscode's request to process the arg and run the batch failed. Even the command requested using DAP runInTerminal wasn't tried. I think this is the same issue as microsoft/vscode#57452

Its almost the same issue but for the integrated console instead of the external one.

I've created a new issue with this finding: microsoft/vscode#140974

@gustavomassa
Copy link

gustavomassa commented Jan 21, 2022

I can confirm the console property works fine on Linux (bash) with "integratedTerminal", and I'm able to use "CTRL + C" signal.
/usr/bin/env GOPATH=/home/gustavomassa/go /home/gustavomassa/go/bin/dlv dap --check-go-version=false --client-addr=:37467

But it does not work for "externalTerminal"
image
image

Example of launch config used:

        {
            "name": "Debug Cli",
            "type": "go",
            "request": "launch",
            "mode": "debug",
            "debugAdapter": "dlv-dap",
            "console": "externalTerminal",
            "cwd": "${workspaceFolder}",
            "program": "${workspaceFolder}/cli/mizu.go",
            "args": [
                "tap",
                "-n",
                "sock-shop"
            ],
        },

@hyangah
Copy link
Contributor

hyangah commented Jan 21, 2022

@gustavomassa Thanks for the report. What is the error message the 'external' terminal shows? It looks like dlv printed out its help message but the screenshot hides the beginning of the error message.

@gustavomassa
Copy link

@gustavomassa Thanks for the report. What is the error message the 'external' terminal shows? It looks like dlv printed out its help message but the screenshot hides the beginning of the error message.

@hyangah
I was trying to find the dlv command on the logs, but I could not find it. The dlv output is not showing the error/command paths :(
image

@hyangah
Copy link
Contributor

hyangah commented Jan 21, 2022

@gustavomassa Is ps still showing the corresponding bash command? On my Linux I see an entry like
bash -c ''/usr/local/home/hakim/go/bin/dlv dap --check-go-version=false --client-addr=:40481 ; echo; read -p "Press any key to continue.... (I couldn't reproduce this so I guess something in your environment tickled a bug in VSCode's runInTerminal implementation.)

@gustavomassa
Copy link

gustavomassa commented Jan 26, 2022

@hyangah I don't know if you changed anything on the extension/code, but it's working fine now

One thing to notice is that the terminal is automatically closed when the program execution ends, can we change this behavior to wait for user input before closing the terminal? For example, if we have an error that terminates the program, the terminal is closed before we can read the error

@hyangah hyangah removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 6, 2022
@hyangah
Copy link
Contributor

hyangah commented Apr 6, 2022

This is done. The only remaining task is probably an entry in FAQ.

@gustavomassa thanks for following up.

can we change this behavior to wait for user input before closing the terminal?

On my Linux, the last command is read -p "Press any key to continue...." which waits for user input before closing the terminal. From your #124 (comment) I see the same. If it doesn't work this time, I recommend filing an issue to vscode team with the details about the platform.

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/406295 mentions this issue: docs/debugging.md: instruction for console and debugging as root

@hyangah
Copy link
Contributor

hyangah commented May 18, 2022

Please find the instruction in https://github.com/golang/vscode-go/wiki/debugging#handling-stdin

@golang golang locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Debug Issues related to the debugging functionality of the extension. FeatureRequest FrozenDueToAge
Projects
None yet
Development

No branches or pull requests