Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump amqplib dependency to avoid bluebird #542

Closed
mkadirtan opened this issue Jan 5, 2023 · 0 comments
Closed

Bump amqplib dependency to avoid bluebird #542

mkadirtan opened this issue Jan 5, 2023 · 0 comments

Comments

@mkadirtan
Copy link

The rabbitmq package adds amqplib^0.8.0 dependency, which is dependent on bluebird. Either use amqplib as peerDependency or update the version please
@underfisk underfisk mentioned this issue Feb 28, 2023
Closed
@witem witem mentioned this issue Jun 3, 2023
Closed
ttshivers added a commit to ttshivers/nestjs that referenced this issue Jan 16, 2024
@ttshivers
build(rabbitmq): update amqp libs
e95c1d9 
Update amqplib and amqp-connection-manager to the latest version.
There are many fixes and improvements.

BREAKING CHANGE: We will no longer emit a disconnect event on an initial connection failure -
instead we now emit connectFailed on each connection failure, and only emit disconnect when we
transition from connected to disconnected.

re golevelup#542
@ttshivers ttshivers mentioned this issue Jan 16, 2024
Closed
ttshivers added a commit to ttshivers/nestjs that referenced this issue Jan 16, 2024
@ttshivers
build(rabbitmq): update amqp libs
ae86763 
Update amqplib and amqp-connection-manager to the latest version.
There are many fixes and improvements.

BREAKING CHANGE: We will no longer emit a disconnect event on an initial connection failure -
instead we now emit connectFailed on each connection failure, and only emit disconnect when we
transition from connected to disconnected.

re golevelup#542
@ttshivers ttshivers mentioned this issue Jan 16, 2024
Merged
underfisk pushed a commit that referenced this issue Jan 16, 2024
@ttshivers
build(rabbitmq): update amqp libs (#677)
83530d3 
Update amqplib and amqp-connection-manager to the latest version.
There are many fixes and improvements.

BREAKING CHANGE: We will no longer emit a disconnect event on an initial connection failure -
instead we now emit connectFailed on each connection failure, and only emit disconnect when we
transition from connected to disconnected.

re #542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@underfisk @mkadirtan