build(rabbitmq): update amqp libs #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update amqplib and amqp-connection-manager to the latest version. There are many fixes and improvements. BREAKING CHANGE: We will no longer emit a disconnect event on an initial connection failure - instead we now emit connectFailed on each connection failure, and only emit disconnect when we transition from connected to disconnected. re golevelup#542
|
@ttshivers Thank you very much for reviving this @WonderPanda The next rabbitmq package version should be a major because this implies breaking changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update amqplib and amqp-connection-manager to the latest version. There are many fixes and improvements.
BREAKING CHANGE: We will no longer emit a disconnect event on an initial connection failure - instead we now emit connectFailed on each connection failure, and only emit disconnect when we transition from connected to disconnected.
re #542
re #459