-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rabbitmq): update amqp-connection-manager to v4 #459
Conversation
@vincent-benbria Is there a way to proxy the old disconnect event, I'm trying to think of a way to bring compatibility to pre-existing code. If not, if we decide that this is a breaking change, please ensure we're only going to have 4.xx I did play with this for a while, this seems good to me but i don't want to either support v3/v4 when there's no proxy or whatsoever so bridge both v3 and v4. |
@vincent-benbria Could you just make sure we're on |
@underfisk would it make sense to bump https://github.com/nestjs/nest/blob/81df0dde0881b0680808798565bc88a0e65dc2ed/package.json#L108 If you'd rather that be in a separate PR, I can do that as well. |
It does make sense, bump it |
amqp-connection-manager
to v4
amqp-connection-manager
to v4
@vincent-benbria I have bumped |
Any ETA for this to be merged? |
This brings compatibility (maybe?) with amqp-connection-manager > 4.0.0
amqp-connection-manager 4.0.0 (2022-01-07)
BREAKING CHANGES
We will no longer emit a disconnect event on an
initial connection failure - instead we now emit connectFailed on each
connection failure, and only emit disconnect when we transition from
connected to disconnected.