Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rabbitmq): update amqp-connection-manager to v4 #459

Closed
wants to merge 13 commits into from

Conversation

vincent-benbria
Copy link
Contributor

This brings compatibility (maybe?) with amqp-connection-manager > 4.0.0

amqp-connection-manager 4.0.0 (2022-01-07)

BREAKING CHANGES
We will no longer emit a disconnect event on an
initial connection failure - instead we now emit connectFailed on each
connection failure, and only emit disconnect when we transition from
connected to disconnected.

@underfisk
Copy link
Contributor

@vincent-benbria Is there a way to proxy the old disconnect event, I'm trying to think of a way to bring compatibility to pre-existing code. If not, if we decide that this is a breaking change, please ensure we're only going to have 4.xx

I did play with this for a while, this seems good to me but i don't want to either support v3/v4 when there's no proxy or whatsoever so bridge both v3 and v4.

@underfisk
Copy link
Contributor

@vincent-benbria Could you just make sure we're on amqp-connection-manager v4 and update the yarn.lock file?

@andrewda
Copy link
Contributor

@underfisk would it make sense to bump amqplib to ^0.10.1 in this PR as well? That should keep it in sync with the latest version of Nest:

https://github.com/nestjs/nest/blob/81df0dde0881b0680808798565bc88a0e65dc2ed/package.json#L108

If you'd rather that be in a separate PR, I can do that as well.

@underfisk
Copy link
Contributor

It does make sense, bump it

@underfisk underfisk changed the title feat(rabbitmq): Compatibility with amqp-connection-manager 3 & 4 chore(rabbitmq): update amqp-connection-manager to v4 Sep 14, 2022
@underfisk underfisk changed the title chore(rabbitmq): update amqp-connection-manager to v4 chore(rabbitmq): update amqp-connection-manager to v4 Sep 14, 2022
@underfisk
Copy link
Contributor

@vincent-benbria I have bumped amqlib as @andrewda suggested and made sure that we are only aiming for v4 from now forward, after reading this major it feels that its important to guide people through v4 using the new api methods

@witem
Copy link

witem commented Jun 2, 2023

Any ETA for this to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants