Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard routing stopped working. RabbitMQ #712

Closed
Andrius0124 opened this issue Mar 23, 2024 · 0 comments · Fixed by #713
Closed

Wildcard routing stopped working. RabbitMQ #712

Andrius0124 opened this issue Mar 23, 2024 · 0 comments · Fixed by #713
Labels

Comments

@Andrius0124
Copy link
Contributor

Andrius0124 commented Mar 23, 2024

#567

Regarding the issue above. It seems that it has broken some existing functionality.

Let me give an example:
@RabbitRPC({ routingKey: "USER.UPDATED.#", queue: "someQueue" }) async handleUserUpdated()
if the message is pushed with routingKey "USER.UPDATED.TEST" the handler will never be hit.
The question is, should the wildcards be respected at that point, or is my initial implementation wrong?

PR added
@WonderPanda

Andrius0124 pushed a commit to Andrius0124/nestjs that referenced this issue Mar 24, 2024
Andrius0124 pushed a commit to Andrius0124/nestjs that referenced this issue Mar 25, 2024
underfisk pushed a commit that referenced this issue Mar 25, 2024
…wildcards (#713)

* fix(rabbitmq): a fix for routing key check. The check should respect wildcards

fix #712

* test(rabbitmq): added tests for matchesRoutingKey and logic improved

re #712

---------

Co-authored-by: andriusm <andriusm@softpauer.com>
WonderPanda pushed a commit that referenced this issue Apr 10, 2024
…wildcards (#713)

* fix(rabbitmq): a fix for routing key check. The check should respect wildcards

fix #712

* test(rabbitmq): added tests for matchesRoutingKey and logic improved

re #712

---------

Co-authored-by: andriusm <andriusm@softpauer.com>
WonderPanda pushed a commit that referenced this issue Apr 10, 2024
…wildcards (#713)

* fix(rabbitmq): a fix for routing key check. The check should respect wildcards

fix #712

* test(rabbitmq): added tests for matchesRoutingKey and logic improved

re #712

---------

Co-authored-by: andriusm <andriusm@softpauer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants