Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rabbitmq): a fix for routing key check. The check should respect wildcards #713

Merged
merged 2 commits into from
Mar 25, 2024
Merged

fix(rabbitmq): a fix for routing key check. The check should respect wildcards #713

merged 2 commits into from
Mar 25, 2024

Conversation

Andrius0124
Copy link
Contributor

Added logic to respect wildcards for the routing keys check
fix #712

@underfisk underfisk enabled auto-merge (squash) March 25, 2024 19:35
underfisk
underfisk approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@underfisk underfisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for adding the test coverage

@underfisk underfisk merged commit 450d420 into golevelup:master Mar 25, 2024
3 checks passed
WonderPanda pushed a commit that referenced this pull request Apr 10, 2024
@Andrius0124 @WonderPanda
fix(rabbitmq): a fix for routing key check. The check should respect …
1ec67f8 
…wildcards (#713)

* fix(rabbitmq): a fix for routing key check. The check should respect wildcards

fix #712

* test(rabbitmq): added tests for matchesRoutingKey and logic improved

re #712

---------

Co-authored-by: andriusm <andriusm@softpauer.com>
WonderPanda pushed a commit that referenced this pull request Apr 10, 2024
@Andrius0124 @WonderPanda
fix(rabbitmq): a fix for routing key check. The check should respect …
735b038 
…wildcards (#713)

* fix(rabbitmq): a fix for routing key check. The check should respect wildcards

fix #712

* test(rabbitmq): added tests for matchesRoutingKey and logic improved

re #712

---------

Co-authored-by: andriusm <andriusm@softpauer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underfisk underfisk underfisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wildcard routing stopped working. RabbitMQ
2 participants
@Andrius0124 @underfisk