fix issues#667 #671
Closed
fix issues#667 #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liudichen Thank you for the contribution! Would you be able to develop some test coverage to assert that this functionality works as intended? |
ttshivers
added a commit
to ttshivers/nestjs
that referenced
this pull request
Jan 15, 2024
This is an attempt to fix the issue where this library doesn't pass the right arguments to setupQueue in setupQueuesWithBindings. In addition, this removes the duplicate setup that setupQueuesWithBindings was doing that setupQueue alredy does. re golevelup#671
|
@ttshivers Is this still applicable or shall i close it? |
|
This shouldn't be needed anymore since my fix merged at #676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix issue # 667:
At present, the queue name attribute corresponds to the queue attribute in Message HandlerOptions, while it corresponds to the name in RabbitMQQueueConfig. There is also an issue of inconsistent queueOptions and options attribute names.
This can cause RabbitMQ to create many anonymous queues (unable to consume and automatically delete) due to no queue in RabbitMQQueueConfig, or channel initialization errors due to different configurations of the same queue at different locations due to the lack of queueOptions.