Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rabbitmq): fix library asserting queues with empty names #676

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

ttshivers
Copy link
Contributor

This is an attempt to fix the issue where this library doesn't pass the right arguments to setupQueue in setupQueuesWithBindings. In addition, this removes the duplicate setup that setupQueuesWithBindings was doing that setupQueue alredy does.

re #667

This is an attempt to fix the issue where this library doesn't pass the right arguments to
setupQueue in setupQueuesWithBindings. In addition, this removes the duplicate setup that
setupQueuesWithBindings was doing that setupQueue alredy does.

re golevelup#667
Copy link
Contributor

@underfisk underfisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, ty

@underfisk underfisk enabled auto-merge (squash) January 16, 2024 10:42
@underfisk underfisk merged commit 24757f3 into golevelup:master Jan 16, 2024
3 checks passed
@ttshivers ttshivers deleted the fix/empty-queue branch January 16, 2024 17:18
@ttshivers ttshivers mentioned this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants