fix(rabbitmq): fix unawaited promises #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed some floating promises in the code when trying to debug an issue due to ordering. Ensuring all the promises are awaited where expected should help prevent possible issues like ensureing the assertExchange is done before trying to bind a queue to it.
|
@ttshivers Thank you for this change! Would you be down to write some test coverage to assert what you're describing/what we're trying to accomplish here? |
I have written a test that fails before my fix and passes after my fix which exposes one of the race conditions that is possible by not awaiting the promises. |
ttshivers
force-pushed
the
fix/rabbitmq-promises
branch
2 times, most recently
from
dc90d5a
to
8ff8702
Compare
Add test for race condition
ttshivers
force-pushed
the
fix/rabbitmq-promises
branch
from
8ff8702
to
e0f9974
Compare
underfisk
approved these changes
Jan 16, 2024
|
@ttshivers could you update the branch and fix conflicts? |
I have resolved the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some floating promises in the code when trying to debug an issue due to ordering. Ensuring all the promises are awaited where expected should help prevent possible issues like ensureing the assertExchange is done before trying to bind a queue to it.