Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rabbitmq): fix unawaited promises #674

Merged
merged 3 commits into from
Jan 16, 2024
Merged

fix(rabbitmq): fix unawaited promises #674

merged 3 commits into from
Jan 16, 2024

Commits on Jan 15, 2024

  1. fix(rabbitmq): fix unawaited promises 

    I noticed some floating promises in the code when trying to debug an issue due to ordering. Ensuring
all the promises are awaited where expected should help prevent possible issues like ensureing the
assertExchange is done before trying to bind a queue to it.
    @ttshivers
    ttshivers committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    0e42f93 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. fix: add test for race condition 

    Add test for race condition
    @ttshivers
    ttshivers committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    e0f9974 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into fix/rabbitmq-promises

    @ttshivers
    ttshivers committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    c8c1a7d View commit details
    Browse the repository at this point in the history