-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pass along model version in GenerateContentResponse #621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the PR. Could you revert the generated docs? We'll refresh those with the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, interesting. Tests are failing because the generated client library doesn't have that attribute. So this needs a new release of the client lib before we can merge.
Thanks Mark for the review! Reverted docs.
To clarify, did I miss adding the |
I need to release a new version and update the dependancies in setup.py. cl/693090666 |
Description of the change
Pass along model version in GenerateContentResponse.
Motivation
b/378140421
Type of change
Bug fix
Checklist
git pull --rebase upstream main
).