Fix arg length error, add multimodal examples, update video prompt #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishal-dharm
added
the
status:awaiting review
MarkDaoust
approved these changes
Nov 16, 2024
MarkDaoust
approved these changes
Nov 16, 2024
|
Thanks! |
github-actions
bot
removed
the
status:awaiting review
Annhiluc
pushed a commit
to Annhiluc/generative-ai-python
that referenced
this pull request
Nov 22, 2024
MarkDaoust
pushed a commit
that referenced
this pull request
Nov 26, 2024
* fix: Pass along model_version in GenerateContentResponse. * Revert autogenerated doc files from 94eb16e. * Fix 'argument list too long' error and add couple vision examples (#634) * Update google-ai-generativelanguage version in requirements. * Format updated generation_types and test using black. --------- Co-authored-by: Vishal Dharmadhikari <61256217+vishal-dharm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR fixes the "argument list too long" error in the
text_generation.shfile when using large base64 encoded images by using temporary files to store the encoded data and the JSON payload. This resolves issues encountered when running thetext_gen_multimodal_one_image_promptandtext_gen_multimodal_one_image_prompt_streamingexamples.This PR also makes the following additions and updates:
Adds two new multimodal vision examples to
text_generation.sh:text_gen_multimodal_two_image_prompt: Demonstrates using two images in a single prompt.text_gen_multimodal_one_image_bounding_box_prompt: Shows how to generate bounding boxes for objects.Updates the
text_gen_multimodal_video_promptexample: The prompt is now more comprehensive and does a better job demonstrating Gemini 1.5's multimodal capabilities.Motivation
These examples are being added so they can be included in the revamped vision documentation.
Type of change
Feature request
Checklist
git pull --rebase upstream main).