-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 100ms delay to the AutoComplete action in emulator tests to fix the test flakiness #1338
Add 100ms delay to the AutoComplete action in emulator tests to fix the test flakiness #1338
Conversation
can you please rename the PR to something more readable and not use the branch name as part of it? thanks |
Codecov Report
@@ Coverage Diff @@
## master #1338 +/- ##
============================================
+ Coverage 84.53% 84.57% +0.03%
Complexity 687 687
============================================
Files 148 148
Lines 10701 10701
Branches 832 832
============================================
+ Hits 9046 9050 +4
+ Misses 1240 1237 -3
+ Partials 415 414 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @PallaviGanorkar for fixing this!
...androidTest/java/com/google/android/fhir/datacapture/utilities/AutoCompleteTextViewAction.kt
Show resolved
Hide resolved
* Use `setValue` method to set the primitive data field value in extraction * Revert unnecessary change * Address review comment to use named param * Address some IDE suggestions to improve code * Address #1338 (comment)
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1323
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.