Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 100ms delay to the AutoComplete action in emulator tests to fix the test flakiness #1338

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

PallaviGanorkar
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1323

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10
Copy link
Collaborator

can you please rename the PR to something more readable and not use the branch name as part of it? thanks

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1338 (c93c73a) into master (98fd148) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1338      +/-   ##
============================================
+ Coverage     84.53%   84.57%   +0.03%     
  Complexity      687      687              
============================================
  Files           148      148              
  Lines         10701    10701              
  Branches        832      832              
============================================
+ Hits           9046     9050       +4     
+ Misses         1240     1237       -3     
+ Partials        415      414       -1     
Impacted Files Coverage Δ
...iews/QuestionnaireItemDropDownViewHolderFactory.kt 65.71% <0.00%> (+11.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f380ec...c93c73a. Read the comment docs.

@jingtang10 jingtang10 changed the title Pg/1323 flakey test Add 100ms delay to the AutoComplete action in emulator tests to fix the tse flakiness Apr 27, 2022
@jingtang10 jingtang10 changed the title Add 100ms delay to the AutoComplete action in emulator tests to fix the tse flakiness Add 100ms delay to the AutoComplete action in emulator tests to fix the test flakiness Apr 27, 2022
@jingtang10 jingtang10 enabled auto-merge (squash) April 27, 2022 08:23
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @PallaviGanorkar for fixing this!

@jingtang10 jingtang10 merged commit 13aa710 into google:master Apr 27, 2022
jingtang10 added a commit to jingtang10/android-fhir that referenced this pull request May 5, 2022
jingtang10 added a commit that referenced this pull request May 5, 2022
* Use `setValue` method to set the primitive data field value in extraction

* Revert unnecessary change

* Address review comment to use named param

* Address some IDE suggestions to improve code

* Address #1338 (comment)
@Tarun-Bhardwaj Tarun-Bhardwaj added the type:testing Improvements on tests or testing infrastructure label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:testing Improvements on tests or testing infrastructure
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

DropDown widget Espresso tests flaky
3 participants