Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 100ms delay to the AutoComplete action in emulator tests to fix the test flakiness #1338

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Add 100ms delay to the AutoComplete action in emulator tests to fix the test flakiness #1338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7f9155
Flakey Test case fixed
PallaviGanorkar Apr 26, 2022
22c6e45
Flakey Test case fixed
PallaviGanorkar Apr 26, 2022
c93c73a
Spotless check applied
PallaviGanorkar Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...roidTest/java/com/google/android/fhir/datacapture/utilities/AutoCompleteTextViewAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ fun showDropDown(): ViewAction {
override fun perform(uiController: UiController, view: View?) {
val autoCompleteTextView = view as AutoCompleteTextView
autoCompleteTextView.showDropDown()
uiController.loopMainThreadUntilIdle()
uiController.loopMainThreadForAtLeast(100)
jingtang10 marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
2 changes: 0 additions & 2 deletions .../android/fhir/datacapture/views/QuestionnaireItemDropDownViewHolderFactoryEspressoTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import org.hl7.fhir.r4.model.Coding
import org.hl7.fhir.r4.model.Questionnaire
import org.hl7.fhir.r4.model.QuestionnaireResponse
import org.junit.Before
import org.junit.Ignore
import org.junit.Rule
import org.junit.Test

Expand Down Expand Up @@ -73,7 +72,6 @@ class QuestionnaireItemDropDownViewHolderFactoryEspressoTest {
}

@Test
@Ignore("https://github.com/google/android-fhir/issues/1323")
fun shouldSetDropDownValueToAutoCompleteTextView() {
val questionnaireItemViewItem =
QuestionnaireItemViewItem(
Expand Down