Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Dokka configs for different modules into a common DokkaConfig.kt file #1503

Merged
merged 11 commits into from
Jul 26, 2022

Conversation

jingtang10
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1457

Change on top of #1466

Description

  • Create DokkaConfig.kt file in /buildSrc
  • Upgrade AGP plugin to 7.2.1

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Documentation

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

williamito added a commit to williamito/android-fhir that referenced this pull request Jul 25, 2022
@jingtang10 jingtang10 changed the title Add DokkaConfig to create API docs Move Dokka configs for different modules into a common DokkaConfig.kt file Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #1503 (cd161b8) into master (d715db4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1503   +/-   ##
=========================================
  Coverage     74.56%   74.56%           
  Complexity      660      660           
=========================================
  Files           128      128           
  Lines          3995     3995           
  Branches        726      726           
=========================================
  Hits           2979     2979           
  Misses          620      620           
  Partials        396      396           

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit!

buildSrc/build.gradle.kts Outdated Show resolved Hide resolved
@jingtang10 jingtang10 enabled auto-merge (squash) July 26, 2022 13:15
@jingtang10 jingtang10 merged commit c846da8 into google:master Jul 26, 2022
jingtang10 pushed a commit that referenced this pull request Jul 27, 2022
* Regenerate docs at latest public version using #1503 code

* redo without test

* add deletions

Co-authored-by: Omar Ismail <44980219+omarismail94@users.noreply.github.com>
@Tarun-Bhardwaj Tarun-Bhardwaj added type:build Issues related to code build type:documentation Improvements or additions to documentation and removed type:build Issues related to code build labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Integrate Dokka into all SDK components and build API reference docs
3 participants