Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate docs at latest public version using #1503 code #1504

Merged
merged 7 commits into from
Jul 27, 2022

Conversation

williamito
Copy link
Contributor

@williamito williamito commented Jul 25, 2022

Fixes
#1457

Description
The doc generation code in #1503 results in pages using a newer Dokka theme than my original PR. This PR regenerates the currently checked-in docs using the new theme, resulting in a very noisy set of files changed but the actual content is the same.

Type
Documentation

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1504 (041e5ed) into master (5d6f671) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1504   +/-   ##
=========================================
  Coverage     74.71%   74.71%           
  Complexity      685      685           
=========================================
  Files           133      133           
  Lines          4189     4189           
  Branches        738      738           
=========================================
  Hits           3130     3130           
  Misses          654      654           
  Partials        405      405           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@williamito
Copy link
Contributor Author

It appears that test code is now getting picked up in the doc gen; I think I know what the fix on top of #1503 would be to avoid this.

@jingtang10
Copy link
Collaborator

thanks @williamito please update this pr once your fix is merged

@williamito
Copy link
Contributor Author

Omitted test dirs
@jingtang10 PTAL

@jingtang10
Copy link
Collaborator

do you want to update this now that #1470 is in?

otherwise happy to merge.

@jingtang10 jingtang10 enabled auto-merge (squash) July 27, 2022 16:55
@jingtang10 jingtang10 merged commit f5dd644 into google:master Jul 27, 2022
@Tarun-Bhardwaj Tarun-Bhardwaj added type:documentation Improvements or additions to documentation Data capture labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants