Fix issue with duplicated IDs inside the Knowledge Manager #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plicated, it would not filter by type and return the wrong one. This fixes it while also enforcing the id to be a complete word in the URL
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Oct 13, 2023
- With unmerged PR #11 - Wup google#1669 - Wup #9 - Wup google#2178 - Wup #10 - Wup google#2230 - Wup google#2262
omarismail94
approved these changes
Oct 13, 2023
jingtang10
requested changes
Oct 13, 2023
There was a problem hiding this comment.
- please add tests.
- is this definitely the right fix? trying to match part of the url is still weird to me. if there is an id that is a substring of another id, the result isn't guaranteed... i have been a little worried about this actually regarding id and name... seems really confusing in our code.
|
let's not merge this as is - i think we still have issues to address here. |
7 tasks
|
closing in favour of the new pr. thx vitor! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search by ID in the KnowledgeManager was used to return only the first reference. If the ID was duplicated in the DB, it would not filter by type and return the wrong one. This fixes it while also enforcing the ID to be a complete word in the URL
Type
Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.