Overrides Ids when installing an IG #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Updates files to match id 3. Updates test case framework to not rely in Ids, because they will change 4. Updates FhirOperator interface to offer a way to not use the internal Id when selecting a PlanDefinition 5. Updates test cases to match the new output ids.
jingtang10
requested changes
Oct 17, 2023
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/db/dao/KnowledgeDao.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Show resolved
Hide resolved
jingtang10
reviewed
Oct 17, 2023
# Conflicts: # workflow/src/main/java/com/google/android/fhir/workflow/FhirOperator.kt # workflow/src/test/java/com/google/android/fhir/workflow/FhirOperatorTest.kt
…urce metadata entity db table... so this function can actually be simplified to remove the resource type parameter.
jingtang10
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A draft solution to make sure the searchById in the Knowledge Manager works without searching by part of the URL.
Replaces: #2262
This PR:
idwhen installing Knowledge Artifactsidid, because they will changeidwhen selecting a PlanDefinitionidsType
Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.