feat: add basic pasters #7331
Merged
feat: add basic pasters #7331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export class BlockPaster implements IPaster<BlockCopyData, BlockSvg> { | ||
| paste( | ||
| copyData: BlockCopyData, | ||
| workspace: WorkspaceSvg, |
There was a problem hiding this comment.
Does the existing copy/paste system work with headless workspaces? If no, we can decide that working in headless is out of scope, and then this code gets to be simple. If yes, we have to decide whether to keep that or deliberately break it.
There was a problem hiding this comment.
Current code only works in rendered workspaces! Blocks are not ICopyable only BlockSvgs are =) Same for workspace comments.
rachel-fenichel
approved these changes
Jul 28, 2023
BeksOmega
force-pushed
the
feat/basic-pasters
branch
from
2ed4271
to
fd1360a
Compare
github-actions
bot
added
PR: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7336
Proposed Changes
Add an IPaster interface and pasters for blocks and workspace comments.
Reason for Changes
Work toward having separate pasters for separate objects so that we can easily add new pastable objects.
Test Coverage
N/A - This is just using the serialization system so no need to test it separately. I'll add tests for the integration between the clipboard and the pasters when I get to that point! (I.e. to make sure the correct APIs are getting called).
Documentation
N/A
Additional Information
Currently these are not actually used anywhere :P I'm going to wire them in in a future PR.