-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic pasters #7331
Merged
BeksOmega
merged 2 commits into
google:operation-copy-that
from
BeksOmega:feat/basic-pasters
Jul 31, 2023
Merged
feat: add basic pasters #7331
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/** | ||
* @license | ||
* Copyright 2023 Google LLC | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
import {BlockSvg} from '../block_svg.js'; | ||
import {CopyData} from '../interfaces/i_copyable'; | ||
import {IPaster} from '../interfaces/i_paster.js'; | ||
import {State, append} from '../serialization/blocks'; | ||
import {Coordinate} from '../utils/coordinate.js'; | ||
import {WorkspaceSvg} from '../workspace_svg.js'; | ||
|
||
export class BlockPaster implements IPaster<BlockCopyData, BlockSvg> { | ||
paste( | ||
copyData: BlockCopyData, | ||
workspace: WorkspaceSvg, | ||
coordinate?: Coordinate, | ||
): BlockSvg | null { | ||
if (!workspace.isCapacityAvailable(copyData.typeCounts!)) return null; | ||
|
||
const state = copyData.saveInfo as State; | ||
if (coordinate) { | ||
state['x'] = coordinate.x; | ||
state['y'] = coordinate.y; | ||
} | ||
return append(state, workspace, {recordUndo: true}) as BlockSvg; | ||
} | ||
} | ||
|
||
export interface BlockCopyData extends CopyData {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/** | ||
* @license | ||
* Copyright 2023 Google LLC | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
import {IPaster} from '../interfaces/i_paster.js'; | ||
import {CopyData} from '../interfaces/i_copyable.js'; | ||
import {Coordinate} from '../utils/coordinate.js'; | ||
import {WorkspaceSvg} from '../workspace_svg.js'; | ||
import {WorkspaceCommentSvg} from '../workspace_comment_svg.js'; | ||
|
||
export class WorkspaceCommentPaster | ||
implements IPaster<WorkspaceCommentCopyData, WorkspaceCommentSvg> | ||
{ | ||
paste( | ||
copyData: WorkspaceCommentCopyData, | ||
workspace: WorkspaceSvg, | ||
coordinate?: Coordinate, | ||
): WorkspaceCommentSvg { | ||
const state = copyData.saveInfo as Element; | ||
if (coordinate) { | ||
state.setAttribute('x', `${coordinate.x}`); | ||
state.setAttribute('y', `${coordinate.y}`); | ||
} | ||
return WorkspaceCommentSvg.fromXmlRendered(state, workspace); | ||
} | ||
} | ||
|
||
export interface WorkspaceCommentCopyData extends CopyData {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
/** | ||
* @license | ||
* Copyright 2023 Google LLC | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
import {Coordinate} from '../utils/coordinate.js'; | ||
import {WorkspaceSvg} from '../workspace_svg.js'; | ||
import {ICopyable, CopyData} from './i_copyable.js'; | ||
|
||
/** An object that can paste data into a workspace. */ | ||
export interface IPaster<U extends CopyData, T extends ICopyable> { | ||
paste( | ||
copyData: U, | ||
workspace: WorkspaceSvg, | ||
coordinate?: Coordinate, | ||
): T | null; | ||
} | ||
|
||
/** @returns True if the given object is a paster. */ | ||
export function isPaster(obj: any): obj is IPaster<CopyData, ICopyable> { | ||
return obj.paste !== undefined; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the existing copy/paste system work with headless workspaces? If no, we can decide that working in headless is out of scope, and then this code gets to be simple. If yes, we have to decide whether to keep that or deliberately break it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current code only works in rendered workspaces!
Block
s are notICopyable
onlyBlockSvg
s are =) Same for workspace comments.