Reorder Scanner fields to fix alignment issues #464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go doesn't always guarantee 64-bit alignment of 64-bit integer, which leads to crashes when atomic operations are used on them on certain platforms (e.g. ARM).
This problem is described here: https://golang.org/pkg/sync/atomic/#pkg-note-BUG
By putting these fields first, proper alignment will be guaranteed.
golang/go#599
golang/go#23345
This is how crash looks like: