Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder Scanner fields to fix alignment issues #464

Merged
merged 1 commit into from
Feb 25, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions scanner/scanner.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,8 @@ func DefaultScannerOptions() *ScannerOptions {

// Scanner is a tool to scan all the entries in a CT Log.
type Scanner struct {
fetcher *Fetcher

// Configuration options for this Scanner instance.
opts ScannerOptions
// N.B. 64-bit fields must be first due to
// https://golang.org/pkg/sync/atomic/#pkg-note-BUG

// Counters of the number of certificates scanned and matched.
certsProcessed int64
Expand All @@ -73,6 +71,11 @@ type Scanner struct {

unparsableEntries int64
entriesWithNonFatalErrors int64

fetcher *Fetcher

// Configuration options for this Scanner instance.
opts ScannerOptions
}

// entryInfo represents information about a log entry.
Expand Down