[x86] Embed brand_string and mark FillX86BrandString as deprecated #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchatelet
added
code health
API Change
Mizux
reviewed
Jan 14, 2022
Mizux
approved these changes
Jan 14, 2022
gchatelet
force-pushed
the
embed_brand_string
branch
from
454867d to
29c111d
Compare
Mizux
approved these changes
Jan 14, 2022
toor1245
reviewed
Jan 14, 2022
| @@ -184,6 +184,7 @@ static int IsVendorByX86Info(const X86Info* info, const char* const name) { | |||
| return equals(info->vendor, name, sizeof(info->vendor)); | |||
| } | |||
|
|
|||
| // TODO: Remove when deprecation period is over, | |||
There was a problem hiding this comment.
what depreciation period?
There was a problem hiding this comment.
At least two releases, I'll add it to the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.