API change: embed brand_string in GetX86Info()
#198
Conversation
| return false; | ||
| static bool HasSecondFMA(const X86Info* info) { | ||
| switch (info->model) { | ||
| case 0x55: { // Skylake server |
There was a problem hiding this comment.
@jeffhammond would it make sense to use the result of GetX86Microarchitecture here instead of hardcoded models?
Granted that we don't yet have an entry for SKX alone (it is currently embedded in SKL)
For instance, I think this code would return true for an AMD processor HasSecondFMA is part of ParseCpuId which is called for both Intel and AMD cpus.
There was a problem hiding this comment.
I moved to NVIDIA in March and work on ARM CPU stuff now, so I don't have a strong opinion about this topic anymore. @fenrus75 or somebody in his team might be able to help now.
There was a problem hiding this comment.
Congrats on your new position !
Waiting for @fenrus75 input then.
gchatelet
added
the
API Change
|
@gchatelet, do we need to close this PR? Since already merged into master #214 |
This is an API change.
It reduces the chance that user passes an invalid buffer to
FillBrandString