added air source heat pump #1002
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shambergoldstein
requested changes
Jun 13, 2023
| - CONTROL | ||
|
|
||
| CPM2X: |
There was a problem hiding this comment.
I would expect these to have commands with them. The statuses are not very helpful on their own.
There was a problem hiding this comment.
I believe these pumps are cycled automatically, for example: pump A used for 1 day, B used the next day etc
| @@ -162,3 +162,16 @@ PMP_SS_VSC_NONCANONICAL_2: | |||
| - mixing_valve_percentage_command | |||
| - chilled_supply_water_temperature_setpoint | |||
| - chilled_supply_water_temperature_sensor | |||
|
|
|||
|
|
|||
| PMP_SS_REFPM_REFSM_OA_CPM2X: | |||
There was a problem hiding this comment.
See CPM2X comment above.
cstirdivant
requested changes
Jun 16, 2023
| @@ -162,3 +162,16 @@ PMP_SS_VSC_NONCANONICAL_2: | |||
| - mixing_valve_percentage_command | |||
| - chilled_supply_water_temperature_setpoint | |||
| - chilled_supply_water_temperature_sensor | |||
|
|
|||
|
|
|||
| PMP_SS_REFPM_REFSM_OA_CPM2X: | |||
There was a problem hiding this comment.
If this is an air-source heat pump it does not belong in the PMP file, this would be a CH or perhaps a new general type altogether.
cstirdivant
requested changes
Jul 25, 2023
| @@ -566,6 +566,17 @@ CH_SS_SCHWTC_CDWFRM_CHWSWISOVM_CWSISOVM_CHWDPM_CHWFRM_CWDT_REFPM_IGM_DXSWC: | |||
| - IGM | |||
| - DXSWC | |||
|
|
|||
| CH_SS_REFPM_REFSM_OA_CPM2X: | |||
There was a problem hiding this comment.
- Is this heat pump air or water side (is the refrigerant cooling/heating water or air?)
- There is no temperature control on this type; what does the heat pump control to? I would expect to see some supply or return water temperature control.
- You've noted that there are two evaporator pumps, I am unfamilar with this type of configuration
Can you please email a diagram (schematic or BMS screenshot) to digitalbuildings-support@googlegroups.com ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.