Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added air source heat pump #1002

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

added air source heat pump #1002

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ccbd0b0
added air source heat pump
kevin-hereworks Apr 4, 2023
20adba3
changed field names
kevin-hereworks Apr 4, 2023
bf30840
fixed implemented ttype
kevin-hereworks Apr 4, 2023
dff7253
Merge branch 'master' into new-air-source-heat-pump
cstirdivant Jun 14, 2023
e397520
update branch
kevin-hereworks Jul 25, 2023
74fea58
Merge branch 'google:master' into new-air-source-heat-pump
kevin-hereworks Jul 25, 2023
5f74dd3
moved to chiller
kevin-hereworks Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6618,3 +6618,13 @@ VMADC:
- mixed_air_damper_percentage_sensor
implements:
- CONTROL

CPM2X:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect these to have commands with them. The statuses are not very helpful on their own.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these pumps are cycled automatically, for example: pump A used for 1 day, B used the next day etc

description: "circulation pump monitoring X2"
is_abstract: true
uses:
- circulation_pump_run_status_1
- circulation_pump_run_status_2
implements:
- MONITORING

13 changes: 13 additions & 0 deletions ontology/yaml/resources/HVAC/entity_types/PMP.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,3 +162,16 @@ PMP_SS_VSC_NONCANONICAL_2:
- mixing_valve_percentage_command
- chilled_supply_water_temperature_setpoint
- chilled_supply_water_temperature_sensor


PMP_SS_REFPM_REFSM_OA_CPM2X:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See CPM2X comment above.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is an air-source heat pump it does not belong in the PMP file, this would be a CH or perhaps a new general type altogether.

description: "air source heat pump with refrigerant temperature and pressure monitoring, 2 evaporator pumps"
is_canonical: true
implements:
- PMP
- SS
- REFM
- REFSM
- OA
- CPM2X