Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new sensor type #997

Closed

Conversation

kevin-hereworks
Copy link
Contributor

No description provided.

@kevin-hereworks kevin-hereworks marked this pull request as ready for review March 31, 2023 15:00
@mschulze17 mschulze17 added the P2 Medium priority (default) label Apr 5, 2023
description: "Zone temperature monitoring for MDF room with high & low temperature alarms, sensor failed alarm "
is_abstract: true
uses:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make alarms opt_uses

- low_zone_air_temperature_alarm
- failed_zone_air_temperature_alarm
- failed_alarm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need failed_alarm here. These should typically go on general types or on SS.

- CONTROL

MAZTM:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the MA stand for? Should be ZTC rather than ZTM since you have setpoints (controlling rather than monitoring).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt think it was quite controlling though, the setpoints are to set the temperature at which the alarm is triggered?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are including the alarm points themselves there is no need to include the thresholds at which the alarms are triggered.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using the existing ZTM type if possible, there is nothing special about zone temp monitoring in an MDF room that would require a new type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay closing, thank you

@@ -243,3 +243,10 @@ SENSOR_CO2M_VOCM:
- /SENSOR
- CO2M
- VOCM

SENSOR_MAZTM:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not making sense to me to have an abstract type that contains setpoints on a sensor entity. This seems like just a zone temperature sensor to me, and the different setpoints should go on the AHU or whatever this sensor applies to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay yeah this probably makes more sense

- CONTROL

MAZTM:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using the existing ZTM type if possible, there is nothing special about zone temp monitoring in an MDF room that would require a new type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority (default)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants