Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new sensor type #997

Closed
wants to merge 3 commits into from
Closed

added new sensor type #997

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
263c3dc
added new sensor type
kevin-hereworks Mar 31, 2023
d21e070
Merge branch 'master' into new-sensor-type
cstirdivant Jun 14, 2023
892dc64
Merge branch 'master' into new-sensor-type
cstirdivant Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6618,3 +6618,18 @@ VMADC:
- mixed_air_damper_percentage_sensor
implements:
- CONTROL

MAZTM:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the MA stand for? Should be ZTC rather than ZTM since you have setpoints (controlling rather than monitoring).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt think it was quite controlling though, the setpoints are to set the temperature at which the alarm is triggered?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are including the alarm points themselves there is no need to include the thresholds at which the alarms are triggered.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using the existing ZTM type if possible, there is nothing special about zone temp monitoring in an MDF room that would require a new type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay closing, thank you

description: "Zone temperature monitoring for MDF room with high & low temperature alarms, sensor failed alarm "
is_abstract: true
uses:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make alarms opt_uses

- high_limit_zone_air_temperature_setpoint
- low_limit_zone_air_temperature_setpoint
- zone_air_temperature_sensor
- high_zone_air_temperature_alarm
- low_zone_air_temperature_alarm
- failed_zone_air_temperature_alarm
- failed_alarm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need failed_alarm here. These should typically go on general types or on SS.

implements:
- OPERATIONAL

7 changes: 7 additions & 0 deletions ontology/yaml/resources/HVAC/entity_types/SENSOR.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,3 +243,10 @@ SENSOR_CO2M_VOCM:
- /SENSOR
- CO2M
- VOCM

SENSOR_MAZTM:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not making sense to me to have an abstract type that contains setpoints on a sensor entity. This seems like just a zone temperature sensor to me, and the different setpoints should go on the AHU or whatever this sensor applies to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay yeah this probably makes more sense

description: "zone temperature monitoring with high, low alarm setpoints and unit failed alarms"
is_canonical: true
implements:
- /SENSOR
- MAZTM
8 changes: 8 additions & 0 deletions ontology/yaml/resources/fields/telemetry_fields.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3110,3 +3110,11 @@ literals:
- ultraviolet_irradiance_sensor:
fixed_min: 0.0
flexible_max: 2000.0

- high_limit_zone_air_temperature_setpoint:
fixed_min: 255.9259259
flexible_max: 338.7037037

- low_limit_zone_air_temperature_setpoint:
fixed_min: 255.9259259
flexible_max: 338.7037037