Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab pane, persistence of language: js error #1232

Closed
deining opened this issue Sep 9, 2022 · 0 comments · Fixed by #1233
Closed

Tab pane, persistence of language: js error #1232

deining opened this issue Sep 9, 2022 · 0 comments · Fixed by #1233
Labels
regression Feature that has worked before stopped working shortcodes Hugo shortcodes

Comments

@deining
Copy link
Collaborator

deining commented Sep 9, 2022

As mentioned and discused in #1202, a regression was introduced with 10fae88:
When persisting the language of a tab pane, the following error is now thrown in the browser's javascript console:

Uncaught TypeError: $(...).tab is not a function
    <anonymous> http://localhost:1313/js/tabpane-persist.js:7
    <anonymous> http://localhost:1313/js/tabpane-persist.js:6
@deining deining changed the title Tab pane, persistence of langauge: js error Tab pane, persistence of language: js error Sep 9, 2022
deining added a commit to deining/docsy that referenced this issue Sep 9, 2022
@deining
Fix: tab-pane, persistence of language: change load order of .js-scripts
3a9dbd6 
Fix for google#1232
@deining deining mentioned this issue Sep 9, 2022
Merged
@deining deining added regression Feature that has worked before stopped working shortcodes Hugo shortcodes labels Sep 9, 2022
geriom pushed a commit that referenced this issue Sep 12, 2022
@deining @geriom
Fix: tab-pane, persistence of language: change load order of .js-scripts
5a909a9 
Fix for #1232
fekete-robert pushed a commit to fekete-robert/docsy that referenced this issue Sep 13, 2022
@deining @fekete-robert
Fix: tab-pane, persistence of language: change load order of .js-scripts
e30b31b 
Fix for google#1232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression Feature that has worked before stopped working shortcodes Hugo shortcodes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: tab-pane, persistence of language: change load order of .js-scripts deining/docsy
1 participant
@deining