Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: tab-pane, persistence of language: change load order of .js-scripts #1233

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Fix: tab-pane, persistence of language: change load order of .js-scripts #1233

merged 2 commits into from
Sep 12, 2022

Conversation

deining
Copy link
Collaborator

@deining deining commented Sep 9, 2022

This PR fixes #1232. The problem mentioned there is caused by the fact that js/tabpane-persist.js is loaded prior to the bootstrap script. Simply changing the load order of the scripts cures the problem.

@deining deining added regression Feature that has worked before stopped working shortcodes Hugo shortcodes labels Sep 9, 2022
@deining deining requested a review from geriom September 9, 2022 06:55
@LisaFC LisaFC assigned LisaFC and unassigned LisaFC Sep 12, 2022
@LisaFC LisaFC self-requested a review September 12, 2022 14:56
geriom
geriom approved these changes Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@geriom geriom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@geriom geriom merged commit 5a909a9 into google:main Sep 12, 2022
@deining deining deleted the issue-1232 branch September 12, 2022 18:17
@stockholmux stockholmux mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisaFC LisaFC LisaFC approved these changes

@geriom geriom geriom approved these changes

Assignees
No one assigned
Labels
regression Feature that has worked before stopped working shortcodes Hugo shortcodes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tab pane, persistence of language: js error
3 participants
@deining @LisaFC @geriom