-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prism syntax highlighting is active even when prism_syntax_highlighting is false #729
Comments
Huh, that's very weird (and new - I hadn't updated Docsy-example to the latest Docsy version since last month and it's still using Chroma normally) - I'll look at how the CSS is loading, as as far as I can see I last updated Docsy-example after I merged the Markmap PR..... |
So it seems to be only happening in the page with the MarkMap diagram in it - if you look at all the other pages, the docs are still using Chroma. Let me see if I can fix it. |
So I have "fixed" this indirectly by moving the MarkMap diagram to a different page in #750 ... This does not solve the fact that it seems to be loading the Prism files for some reason (does the code in a MarkMap use Prism by default, I wonder?), which will affect every other code snippet on the page. I'll poke at it some more. |
AHA. If I take the fenced code block out of our example MarkMap, the other code blocks on the page use Chroma, as specified. I now just need to figure out how to stop it loading Prism (or if it's possible...). |
Yep, Markmap uses/loads Prism by default - you can switch it off as an option if you're running it from the command line, but we're using an autoloader script that has no parameters. Might file an issue in their repo to see if it's configurable and put a warning/tip in our docs for now - does that make sense? |
Good job tracking that down! Sure that makes sense. If that sort of configuration isn't possible, then maybe we can simply document that hardcoded dependency in the user guide. |
@LisaFC - any updates? |
Thanks for the reminder, looks like it should now be possible to disable Prism in the autoloader so I'm going to give it a try... |
following the instructions here https://markmap.js.org/demos/auto-loader.html?disable=prism related to issue #729
following the instructions here https://markmap.js.org/demos/auto-loader.html?disable=prism related to issue #729
Fixed in #1175 |
following the instructions here https://markmap.js.org/demos/auto-loader.html?disable=prism related to issue google#729
Visit the Docsy User Guide section Look and Feel >> Color palette and other styles. This is the first code block of that section, as syntax highlighted by Chroma:
You'll see that only briefly since Prism sweeps over, changing the highlighting to this:
The problem seems to be that MarkMap (#612) is loading prism, as we can see from the Network view:
The text was updated successfully, but these errors were encountered: