filtering out Prism for markmaps #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
following the instructions here https://markmap.js.org/demos/auto-loader.html?disable=prism related to issue #729
|
checking the network tab in the preview site shows no Prism :) |
|
Excellent, thanks! Fixes #729 |
|
Woohoo! 🎉 |
chalin
reviewed
Aug 18, 2022
Comment on lines
+21
to
+27
| autoLoader: { | ||
| manual: true, | ||
| onReady() { | ||
| const { autoLoader, builtInPlugins } = window.markmap; | ||
| autoLoader.transformPlugins = builtInPlugins.filter(plugin => plugin.name !== 'prism'); | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Hmm, I'm wondering if this should have been added to https://github.com/google/docsy/blob/main/assets/js/markmap.js?
There was a problem hiding this comment.
Created #1188 to track this.
fekete-robert
pushed a commit
to fekete-robert/docsy
that referenced
this pull request
Sep 13, 2022
following the instructions here https://markmap.js.org/demos/auto-loader.html?disable=prism related to issue google#729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following the instructions here https://markmap.js.org/demos/auto-loader.html?disable=prism
related to issue #729