Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer Docsy as a single Hugo Module #1217

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Offer Docsy as a single Hugo Module #1217

merged 3 commits into from
Nov 10, 2023

Conversation

deining
Copy link
Collaborator

@deining deining commented Sep 2, 2022

This PR merges the module docsy and docsy/dependencies into one single module in order to streamline use of Docsy for Hugo Module users. This is a first take at #1120.

@deining deining added the module label Sep 2, 2022
@deining deining requested a review from chalin September 2, 2022 09:26
@deining deining mentioned this pull request Sep 2, 2022
6 tasks
@deining deining marked this pull request as draft September 2, 2022 09:40
@deining
Copy link
Collaborator Author

deining commented Sep 2, 2022

Netlify preview fails, but this was expected.

@chalin
Copy link
Collaborator

chalin commented Oct 7, 2022

@deining - thanks for this. I'm willing to give this a spin. Could you please resolve conflicts (though maybe it is best to wait for #1218 to be merged first).

FYI, v0.5.0 will be released soon. This PR is targeted for a subsequent release (probably v0.6.0).

@deining
Copy link
Collaborator Author

deining commented Oct 10, 2022

Could you please resolve conflicts.

Done.

FYI, v0.5.0 will be released soon. This PR is targeted for a subsequent release (probably v0.6.0).

Great. I can contribute to the documentation and will assist in case of any questions/issues.

@deining deining force-pushed the issue-1120 branch 5 times, most recently from 7b94b7d to b08e422 Compare October 19, 2022 12:19
@deining deining added CI/infra CI & infrastructure cleanup/refactoring labels Oct 24, 2022
@deining deining marked this pull request as ready for review October 24, 2022 06:02
@deining deining marked this pull request as draft October 24, 2022 06:05
@deining deining force-pushed the issue-1120 branch 11 times, most recently from de13647 to 4d86311 Compare October 24, 2022 19:48
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deining - Shouldn't github.com/google/docsy/dependencies entries be removed from go.mod and go.sum?

Also running hugo mod tidy would be a good idea as well, no?

package.json Outdated Show resolved Hide resolved
@deining
Copy link
Collaborator Author

deining commented Nov 9, 2023

@deining - Shouldn't github.com/google/docsy/dependencies entries be removed from go.mod and go.sum?

Yes, very true.

Also running hugo mod tidy would be a good idea as well, no?

Done with commit 396d76d.

@chalin
Copy link
Collaborator

chalin commented Nov 9, 2023

Thanks for the updates.

Have you tested this locally, and if so how? I can't get it to work, whether with using a (slightly modified) version of docsy-example or starting from scratch, again following a modified version of the instructions https://www.docsy.dev/docs/get-started/docsy-as-module/start-from-scratch/.

@deining
Copy link
Collaborator Author

deining commented Nov 9, 2023

Thanks for the updates.

You are welcome.

Have you tested this locally,

Yes.

and if so how?

I started a new site from scratch, created a clone of docsy beside the newly created site repo and used hugo.work to refer to the local docsy theme repo. Similar do what I proposed in another PR from me. Everything ran smoothly, the site was up and running in no time 😄 .

I can't get it to work

I prepared a branch for you on my fork of the docsy-example repo. Please try this:

git clone -b docsy-as-single-module https://github.com/deining/docsy-example docsy-as-single-module-test
hugo server

This works for me out of the box. Can you please give this a try?

@chalin
Copy link
Collaborator

chalin commented Nov 9, 2023

This works for me out of the box. Can you please give this a try?

Yes, it works, thanks!

I also got it to work with a docsy.work file.

@deining
Copy link
Collaborator Author

deining commented Nov 10, 2023

This works for me out of the box. Can you please give this a try?

Yes, it works, thanks!

I also got it to work with a docsy.work file.

Great to hear that!

Do you deem this PR production ready and ready for subsequent merging?
What is still missing and what are the next steps?

@chalin
Copy link
Collaborator

chalin commented Nov 10, 2023

Do you deem this PR production ready and ready for subsequent merging?
What is still missing and what are the next steps?

Almost there! I'd like to address #1217 (comment) first.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@chalin chalin merged commit 580fee0 into google:main Nov 10, 2023
5 checks passed
@chalin
Copy link
Collaborator

chalin commented Nov 10, 2023

In case you missed my nested comment @deining:

How can I check what's in hugo module cache?

@deining
Copy link
Collaborator Author

deining commented Nov 10, 2023

In case you missed my nested comment @deining:

No I didn't miss it!

How can I check what's in hugo module cache?

Find out your cache dir (on my Unix system, this is /home/username/.cache/hugo_cache):

hugo config | grep cachedir

Have a look there, directories you should possibly look at:

~/.cache/hugo_cache/modules/filecache/modules/pkg/mod/github.com/deining/docsy@v0.7.2/

and maybe also

~/.cache/hugo_cache/modules/filecache/modules/pkg/mod/github.com/twbs/bootstrap@v5.2.3+incompatible/
~/.cache/hugo_cache/modules/filecache/modules/pkg/mod/github.com/!fort!awesome/!font-!awesome@v0.0.0-20230327165841-0698449d50f2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants